Bug report #14091

The dev don't support the WMS layer in QR defs

Added by aperi2007 - about 4 years ago. Updated about 4 years ago.

Status:Closed
Priority:Severe/Regression
Assignee:Sebastian Dietrich
Category:Map Canvas
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:
Crashes QGIS or corrupts data:Yes Copied to github as #:22099

Description

The QGIS-dev when saving a wms layer as Definition layer is not readable from the qgis-dem himself.

I test with the qgis 2.12 and it work.

As example, I report a qlr saved with qgis-dev. Updated today.
This sample is saved from qgis-dev,
but it don't work with the same qgis-dev.
Instead it work using qgis 2.12.

sample_wms.zip - a sample of a qlr not working with qgis-dev (1.16 KB) aperi2007 -, 2016-01-12 10:48 PM

sample_project.zip - sample qgis with a wms added directly. (1.89 KB) aperi2007 -, 2016-01-14 02:12 AM

Associated revisions

Revision 0ca359e4
Added by Sebastian Dietrich about 4 years ago

make QLR files containing non-vector layers work again
This was a regression introduced in ff3200fd6c507429b50c56b8307869d62cce6dcf.
(fixes #14091)

Revision 9dd6c0a4
Added by Jürgen Fischer about 4 years ago

Merge pull request #2683 from SebDieBln/FixNonVectorQLR

[Regression] make QLR files containing non-vector layers work again (fixes #14091)

History

#1 Updated by aperi2007 - about 4 years ago

#2 Updated by aperi2007 - about 4 years ago

  • Category set to Symbology

#3 Updated by aperi2007 - about 4 years ago

  • Category changed from Symbology to Map Canvas

#4 Updated by Sebastian Dietrich about 4 years ago

Does it work when saving a project containing this WMS layer?

#5 Updated by aperi2007 - about 4 years ago

I tried this.
I create a new project and drag-n-drop the qlr in it.
I see nothing as reported.
After I save the project and reopen it.

The project is empty.

#6 Updated by Giovanni Manghi about 4 years ago

  • Target version set to Version 2.14
  • Priority changed from Normal to Severe/Regression
  • Crashes QGIS or corrupts data changed from No to Yes

Master (on Windows) also crashes here when opening the attached qlr, is fine on 2.12.2

#7 Updated by Sebastian Dietrich about 4 years ago

Sebastian Dietrich wrote:

Does it work when saving a project containing this WMS layer?

What I meant was:
  • Create a new project
  • Create the WMS layer
  • Save the project
  • Close QGIS and reopen it
  • Open the project

Is the layer there? Does QGIS crash?

Please attach the created project file.

#8 Updated by aperi2007 - about 4 years ago

Sebastian Dietrich wrote:

Sebastian Dietrich wrote:

Does it work when saving a project containing this WMS layer?

What I meant was:
  • Create a new project
  • Create the WMS layer
  • Save the project
  • Close QGIS and reopen it
  • Open the project

Is the layer there? Does QGIS crash?

Please attach the created project file.

No problem with this solution.

I add a project QGIS to this ticket.

#9 Updated by Sebastian Dietrich about 4 years ago

  • Status changed from Open to In Progress
  • Assignee set to Sebastian Dietrich
  • % Done changed from 0 to 30

#10 Updated by Sebastian Dietrich about 4 years ago

See PR 2683 for the solution. It was a regression introduced in ff3200fd6c507429b50c56b8307869d62cce6dcf. QLR files containing non-vector layers triggered this issue.

Interesting observation:
  • Opening an offending QLR via "Load layer definition" crashed QGIS.
  • Opening an offending QLR via drag'n'drop just did nothing.

#11 Updated by Sebastian Dietrich about 4 years ago

  • Pull Request or Patch supplied changed from No to Yes
  • % Done changed from 30 to 100

#12 Updated by Jürgen Fischer about 4 years ago

  • Status changed from In Progress to Closed

Also available in: Atom PDF