Bug report #12172
Use xvfb-run on "make check"
|Affected QGIS version:||master
|Pull Request or Patch supplied:||No
|Crashes QGIS or corrupts data:||No
||Copied to github as #:||20364
I don't think there's any reason for "make check" to map windows on the running desktop, so why not always running xvfb-run when available ?
Make the `check` rule use xvfb-run, drop `check-no-x`
I see no reason for anyone wanting to see popping windows during
a `make check` run. Closes #12172.
I just found out there's a "check-no-x" Makefile rule. Why not making that the default for "check" ?
Or what's the reason to test against the real X ?
As of current master (2.14-pre) I hadn't seen windows popping up on "make check", but there's still a "check-no-x" rule. Was it obsoleted ?
I saw the windows again (maybe last time I just didn't have DISPLAY set). So I think I'll push a change having "make check" run the test w/out X... We need to simplify testing IMHO.
- Regression? set to No
- Easy fix? set to No
- % Done changed from 0 to 100
- Status changed from Open to Closed
Also available in: Atom