Bug report #1213

Attribute Table editing / Stop Editing dialog behavior is confusing

Added by Steven Mizuno about 12 years ago. Updated about 11 years ago.

Status:Closed
Priority:Low
Assignee:nobody -
Category:Data Provider
Affected QGIS version: Regression?:No
Operating System:All Easy fix?:No
Pull Request or Patch supplied: Resolution:fixed
Crashes QGIS or corrupts data: Copied to github as #:11273

Description

1. After opening Attribute Table, if you toggle editing on and then toggle it off without making any changes the Stop Editing dialog appears. If you choose Save or Discard, then subsequent toggling editing on/off without changes does not show the Stop Editing dialog. If Cancel is chosen then the Stop Editing dialog dialog appears again when toggling editing on/off and no changes.

2. in the Stop Editing dialog, if Cancel is chosen then editing is still active, but the Edit button shows off. The Edit button needs to toggled twice to get the Stop Editing dialog now.

3. if editing and changes are pending, attempting to close the Attribute Table closes the window without provoking the Stop Editing dialog. Most users would expect to be asked to save changes. The also would expect to return to editing if Cancel is chosen.

Expected behavior:

+ when editing is active but there are no changes, then the Stop Editing dialog should NOT be presented on stop editing or Attribute Table is closed.

+ when editing is active and there are changes, then the Stop Editing dialog should be presented on stop editing or Attribute Table is closed.

+ Cancel in the Stop Editing dialog should return to editing.

+ the Toggle Editing button should reflect the current editing state.

as of r9010

History

#1 Updated by Jürgen Fischer about 12 years ago

  • Resolution set to fixed
  • Status changed from Open to Closed

fixed in 43278d72 (SVN r9093). Attribute and geometry editing is now unified and the 'toggle editing' buttons trigger the same function. Feel free to reopen, if you still see strange things.

#2 Updated by Anonymous about 11 years ago

Milestone Version 1.0.0 deleted

Also available in: Atom PDF