qgis_render_cache_v3.diff

       //set the state of the checkboxes
       chkAntiAliasing->setChecked( settings.value( "/qgis/enable_anti_aliasing", false ).toBool() );
       chkUseRenderCaching->setChecked( settings.value( "/qgis/enable_render_caching", false ).toBool() );
       // Slightly awkard here at the settings value is true to use QImage,
       // but the checkbox is true to use QPixmap
-...
       settings.setValue( "/qgis/addPostgisDC", cbxAddPostgisDC->isChecked() );
       settings.setValue( "/qgis/new_layers_visible", chkAddedVisibility->isChecked() );
       settings.setValue( "/qgis/enable_anti_aliasing", chkAntiAliasing->isChecked() );
       settings.setValue( "/qgis/enable_render_caching", chkUseRenderCaching->isChecked() );
       settings.setValue( "/qgis/use_qimage_to_render", !( chkUseQPixmap->isChecked() ) );
       settings.setValue( "qgis/capitaliseLayerName", capitaliseCheckBox->isChecked() );
       settings.setValue( "qgis/askToSaveProjectChanges", chbAskToSaveProjectChanges->isChecked() );
-...
       // used (we we can. but it then doesn't do anti-aliasing, and this
       // will confuse people).
       if ( chkAntiAliasing->isChecked() )
+      {
         chkUseQPixmap->setChecked( false );
+      }
+    }
-...
       // used (we we can. but it then doesn't do anti-aliasing, and this
       // will confuse people).
       if ( chkUseQPixmap->isChecked() )
+      {
         chkAntiAliasing->setChecked( false );
+      }
+    }

       // update symbology
       emit refreshLegend( layer->getLayerID(), false );
       if ( layer->cachePixmap() )
+      {
         //no need to delete the old one, maplayer will do it if needed
         layer->setCachePixmap( 0 );
+      }
       layer->triggerRepaint();
       // notify the project we've made a change
       QgsProject::instance()->dirty( true );

         //! current extent to be drawn
         QgsRectangle mExtent;
         //
         /** Last extent to we drew so we know if we can
             used layer render caching or not. Note there are no
             accessors for this as it is intended to internal
             use only.
             @note added in QGIS 1.4 */
         QgsRectangle mLastExtent;
         //! indicates whether it's map image for overview
         bool mOverview;

       mMinScale = 0;
       mMaxScale = 100000000;
       mScaleBasedVisibility = false;
       mpCachePixmap = 0;
+    }
-...
     QgsMapLayer::~QgsMapLayer()
+    {
       delete mCRS;
       if ( mpCachePixmap )
+      {
         delete mpCachePixmap;
+      }
+    }
     QgsMapLayer::LayerType QgsMapLayer::type() const
-...
+    {
       return &mUndoStack;
+    }
     void QgsMapLayer::setCachePixmap( QPixmap * thepPixmap )
+    {
       QgsDebugMsg( "cache Pixmap set!" );
       if ( mpCachePixmap )
+      {
         delete mpCachePixmap;
+      }
       mpCachePixmap = thepPixmap;
+    }

     bool QgsMapRenderer::setExtent( const QgsRectangle& extent )
+    {
       //remember the previous extent
       mLastExtent = mExtent;
       // Don't allow zooms where the current extent is so small that it
       // can't be accurately represented using a double (which is what
-...
     void QgsMapRenderer::render( QPainter* painter )
+    {
       //flag to see if the render context has changed
       //since the last time we rendered. If it hasnt changed we can
       //take some shortcuts with rendering
       bool mySameAsLastFlag = true;
       QgsDebugMsg( "========== Rendering ==========" );
       if ( mExtent.isEmpty() )
-...
+      }
       if ( mDrawing )
+      {
         return;
+      }
       QPaintDevice* thePaintDevice = painter->device();
       if ( !thePaintDevice )
-...
         scaleFactor = sceneDpi / 25.4;
+      }
       double rasterScaleFactor = ( thePaintDevice->logicalDpiX() + thePaintDevice->logicalDpiY() ) / 2.0 / sceneDpi;
       mRenderContext.setScaleFactor( scaleFactor );
       mRenderContext.setRasterScaleFactor( rasterScaleFactor );
       mRenderContext.setRendererScale( mScale );
       if ( mRenderContext.rasterScaleFactor() != rasterScaleFactor )
+      {
         mRenderContext.setRasterScaleFactor( rasterScaleFactor );
         mySameAsLastFlag = false;
+      }
       if ( mRenderContext.scaleFactor() != scaleFactor )
+      {
         mRenderContext.setScaleFactor( scaleFactor );
         mySameAsLastFlag = false;
+      }
       if ( mRenderContext.rendererScale() != mScale )
+      {
         //add map scale to render context
         mRenderContext.setRendererScale( mScale );
         mySameAsLastFlag = false;
+      }
       if ( mLastExtent != mExtent )
+      {
         mLastExtent = mExtent;
         mySameAsLastFlag = false;
+      }
       bool placeOverlays = false;
       QgsOverlayObjectPositionManager* overlayManager = overlayManagerFromSettings();
-...
         placeOverlays = true;
+      }
       //add map scale to render context
       mRenderContext.setRendererScale( mScale );
       // render all layers in the stack, starting at the base
       QListIterator<QString> li( mLayerSet );
       li.toBack();
-...
           break;
+        }
         // Store the painter in case we need to swap it out for the
         // cache painter
         QPainter * mypContextPainter = mRenderContext.painter();
         QString layerId = li.previous();
         QgsDebugMsg( "Rendering at layer item " + layerId );
-...
+            }
+          }
           QSettings mySettings;
           if ( mySettings.value ( "/qgis/enable_render_caching", false ).toBool() )
+          {
             if ( ( !mySameAsLastFlag || ml->cachePixmap() == 0 ) && !split ) //render caching does not yet cater for split extents
+            {
               QPixmap * mypPixmap = new QPixmap( mRenderContext.painter()->device()->width(),
                   mRenderContext.painter()->device()->height() );
               mypPixmap->fill( QColor( 0,0,0,0 ) );
               ml->setCachePixmap( mypPixmap ); //no need to delete the oldone, maplayer does it for you
               QPainter * mypPainter = new QPainter( ml->cachePixmap() );
               if ( mySettings.value( "/qgis/enable_anti_aliasing", false ).toBool() )
+              {
                 mypPainter->setRenderHint( QPainter::Antialiasing );
+              }
               mRenderContext.setPainter( mypPainter  );
+            }
             else if ( mySameAsLastFlag && !split )
+            {
               //always ensure the layers cache pixmap is initialised...
               if ( ! ml->cachePixmap() )
+              {
                 QPixmap * mypPixmap = new QPixmap( mRenderContext.painter()->device()->width(),
                     mRenderContext.painter()->device()->height() );
                 mypPixmap->fill( QColor( 0,0,0,0 ) );
                 ml->setCachePixmap( mypPixmap );
+              }
               //draw from cached image
               mypContextPainter->drawPixmap( 0,0, *(ml->cachePixmap()) );
               disconnect( ml, SIGNAL( drawingProgress( int, int ) ), this, SLOT( onDrawingProgress( int, int ) ) );
               //short circuit as there is nothing else to do...
               continue;
+            }
+          }
           if ( !ml->draw( mRenderContext ) )
+          {
             emit drawError( ml );
-...
             mRenderContext.painter()->restore();
+          }
           //clean up from caching
           if ( mySettings.value ( "/qgis/enable_render_caching", false ).toBool() )
+          {
             if ( !mySameAsLastFlag && !split )
+            {
               //draw from cached image that we created further up
               mypContextPainter->drawPixmap( 0,0, *(ml->cachePixmap()) );
               // reinstate the painter as it was swapped out for caching
               delete mRenderContext.painter();
               mRenderContext.setPainter( mypContextPainter  );
+            }
+          }
           disconnect( ml, SIGNAL( drawingProgress( int, int ) ), this, SLOT( onDrawingProgress( int, int ) ) );
+        }
         else
         else // layer not visible
+        {
           //clear the cache pixmap if we changed resolution / extent
           QSettings mySettings;
           if ( mySettings.value ( "/qgis/enable_render_caching", false ).toBool() )
+          {
             if ( !mySameAsLastFlag )
+            {
               delete ml->cachePixmap();
               ml->setCachePixmap( 0 );
+            }
+          }
           QgsDebugMsg( "Layer not rendered because it is not within the defined "
                        "visibility scale range" );
               "visibility scale range" );
+        }
       } // while (li.hasPrevious())

     #include <QObject>
     #include <QUndoStack>
     #include <QPixmap>
     #include "qgsrectangle.h"
-...
         /** Return pointer to layer's undo stack */
         QUndoStack* undoStack();
         /** Get the QPixmap used for caching render operations
          * @note This method was added in QGIS 1.4 **/
         QPixmap * cachePixmap() { return mpCachePixmap; }
         /** Set the QPixmap used for caching render operations
          * @note This method was added in QGIS 1.4 **/
         void setCachePixmap( QPixmap * thepPixmap );
       public slots:
         /** Event handler for when a coordinate transform fails due to bad vertex error */
-...
         /** A flag that tells us whether to use the above vars to restrict layer visibility */
         bool mScaleBasedVisibility;
         /** Collection of undoable operations for this layer. **/
         QUndoStack mUndoStack;
         /**QPixmap for caching of rendering operations
          * @note This property was added in QGIS 1.4 **/
         QPixmap * mpCachePixmap;
     };
     #endif

        <string>Options</string>
       </property>
       <property name="windowIcon" >
        <iconset>
         <normaloff/>
        </iconset>
        <iconset/>
       </property>
       <property name="sizeGripEnabled" >
        <bool>true</bool>
-...
                </widget>
               </item>
               <item row="1" column="0" colspan="2" >
                <spacer name="verticalSpacer">
                 <property name="orientation">
                <spacer>
                 <property name="orientation" >
                  <enum>Qt::Vertical</enum>
                 </property>
                 <property name="sizeType">
                 <property name="sizeType" >
                  <enum>QSizePolicy::Fixed</enum>
                 </property>
                 <property name="sizeHint" stdset="0">
                 <property name="sizeHint" >
                  <size>
                   <width>20</width>
                   <height>10</height>
                  </size>
                 </property>
                </spacer>
               </item>
               </item>
               <item row="2" column="0" colspan="2" >
                <widget class="QCheckBox" name="capitaliseCheckBox" >
                 <property name="text" >
-...
                 </property>
                </widget>
               </item>
               <item row="3" column="0" colspan="2" >
                <widget class="QCheckBox" name="chkUseRenderCaching" >
                 <property name="text" >
                  <string>Use render caching where possible to speed up redraws</string>
                 </property>
                </widget>
               </item>
              </layout>
             </widget>
            </item>
-...
              </property>
              <property name="sizeHint" >
               <size>
                <width>20</width>
                <height>40</height>
                <width>614</width>
                <height>111</height>
               </size>
              </property>
             </spacer>
-...
       </customwidget>
      </customwidgets>
      <tabstops>
       <tabstop>tabWidget</tabstop>
       <tabstop>chbAskToSaveProjectChanges</tabstop>
       <tabstop>chbWarnOldProjectVersion</tabstop>
       <tabstop>pbnSelectionColour</tabstop>
       <tabstop>pbnCanvasColor</tabstop>
       <tabstop>cmbTheme</tabstop>
       <tabstop>capitaliseCheckBox</tabstop>
       <tabstop>cbxLegendClassifiers</tabstop>
       <tabstop>cbxHideSplash</tabstop>
       <tabstop>cbxIdentifyResultsDocked</tabstop>
       <tabstop>cbxAttributeTableDocked</tabstop>
       <tabstop>cbxAddPostgisDC</tabstop>
       <tabstop>chkAddedVisibility</tabstop>
       <tabstop>spinBoxUpdateThreshold</tabstop>
       <tabstop>chkUseRenderCaching</tabstop>
       <tabstop>chkAntiAliasing</tabstop>
       <tabstop>chkUseQPixmap</tabstop>
       <tabstop>cmbIdentifyMode</tabstop>
       <tabstop>spinBoxIdentifyValue</tabstop>
       <tabstop>cmbEllipsoid</tabstop>
       <tabstop>pbnMeasureColour</tabstop>
       <tabstop>radMeters</tabstop>
       <tabstop>radFeet</tabstop>
       <tabstop>cmbWheelAction</tabstop>
       <tabstop>spinZoomFactor</tabstop>
       <tabstop>mOverlayAlgorithmComboBox</tabstop>
       <tabstop>mLineWidthSpinBox</tabstop>
       <tabstop>mLineColourToolButton</tabstop>
       <tabstop>mDefaultSnapModeComboBox</tabstop>
       <tabstop>mDefaultSnappingToleranceSpinBox</tabstop>
       <tabstop>mSearchRadiusVertexEditSpinBox</tabstop>
       <tabstop>mDefaultSnappingToleranceComboBox</tabstop>
       <tabstop>mSearchRadiusVertexEditComboBox</tabstop>
       <tabstop>mMarkersOnlyForSelectedCheckBox</tabstop>
       <tabstop>mMarkerStyleComboBox</tabstop>
       <tabstop>mMarkerSizeSpinBox</tabstop>
       <tabstop>chkDisableAttributeValuesDlg</tabstop>
       <tabstop>radPromptForProjection</tabstop>
       <tabstop>radUseProjectProjection</tabstop>
       <tabstop>radUseGlobalProjection</tabstop>
-...
       <tabstop>pbnSelectProjection</tabstop>
       <tabstop>grpLocale</tabstop>
       <tabstop>cboLocale</tabstop>
       <tabstop>grpProxy</tabstop>
       <tabstop>leProxyHost</tabstop>
       <tabstop>leProxyPort</tabstop>
       <tabstop>leProxyUser</tabstop>
       <tabstop>leProxyPassword</tabstop>
       <tabstop>mProxyTypeComboBox</tabstop>
       <tabstop>mAddUrlPushButton</tabstop>
       <tabstop>mRemoveUrlPushButton</tabstop>
       <tabstop>mExcludeUrlListWidget</tabstop>
       <tabstop>buttonBox</tabstop>
       <tabstop>tabWidget</tabstop>
      </tabstops>
      <resources/>
      <connections/>

QGIS » QGIS Application