fix #7255 - any editing capability should enable toggle editing

jef-n · jef-n · commit 808547e293da · 2013-03-01T20:18:00.000+01:00
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -7789,10 +7789,9 @@ void QgisApp::activateDeactivateLayerRelatedActions( QgsMapLayer* layer )
       //start editing/stop editing
       if ( dprovider->capabilities() & QgsVectorDataProvider::EditingCapabilities )
       {
-        bool canChangeAttributes = dprovider->capabilities() & QgsVectorDataProvider::ChangeAttributeValues;
-        mActionToggleEditing->setEnabled( canChangeAttributes && !vlayer->isReadOnly() );
+        mActionToggleEditing->setEnabled( !vlayer->isReadOnly() );
         mActionToggleEditing->setChecked( vlayer->isEditable() );
-        mActionSaveLayerEdits->setEnabled( canChangeAttributes && vlayer->isEditable() && vlayer->isModified() );
+        mActionSaveLayerEdits->setEnabled( vlayer->isEditable() && vlayer->isModified() );
         mUndoWidget->dockContents()->setEnabled( vlayer->isEditable() );
         updateUndoActions();
       }

Original file line number	Diff line number	Diff line change
`@@ -7789,10 +7789,9 @@ void QgisApp::activateDeactivateLayerRelatedActions( QgsMapLayer* layer )`
`7789`	`7789`	`//start editing/stop editing`
`7790`	`7790`	`if ( dprovider->capabilities() & QgsVectorDataProvider::EditingCapabilities )`
`7791`	`7791`	`{`
`7792`		`- bool canChangeAttributes = dprovider->capabilities() & QgsVectorDataProvider::ChangeAttributeValues;`
`7793`		`- mActionToggleEditing->setEnabled( canChangeAttributes && !vlayer->isReadOnly() );`
	`7792`	`+ mActionToggleEditing->setEnabled( !vlayer->isReadOnly() );`
`7794`	`7793`	`mActionToggleEditing->setChecked( vlayer->isEditable() );`
`7795`		`- mActionSaveLayerEdits->setEnabled( canChangeAttributes && vlayer->isEditable() && vlayer->isModified() );`
	`7794`	`+ mActionSaveLayerEdits->setEnabled( vlayer->isEditable() && vlayer->isModified() );`
`7796`	`7795`	`mUndoWidget->dockContents()->setEnabled( vlayer->isEditable() );`
`7797`	`7796`	`updateUndoActions();`
`7798`	`7797`	`}`