Protect the const-ituional correctness

m-kuhn · m-kuhn · commit ffb2817afb67 · 2018-04-10T23:10:35.000+02:00
diff --git a/python/gui/processing/qgsprocessingalgorithmconfigurationwidget.sip.in b/python/gui/processing/qgsprocessingalgorithmconfigurationwidget.sip.in
@@ -58,12 +58,12 @@ Interface base class for factories for algorithm configuration widgets.
   public:
     virtual ~QgsProcessingAlgorithmConfigurationWidgetFactory();
 
-    virtual QgsProcessingAlgorithmConfigurationWidget *create( QgsProcessingAlgorithm *algorithm ) const = 0 /Factory/;
+    virtual QgsProcessingAlgorithmConfigurationWidget *create( const QgsProcessingAlgorithm *algorithm ) const = 0 /Factory/;
 %Docstring
 Create a new configuration widget for ``algorithm``.
 %End
 
-    virtual bool canCreateFor( QgsProcessingAlgorithm *algorithm ) const = 0;
+    virtual bool canCreateFor( const QgsProcessingAlgorithm *algorithm ) const = 0;
 %Docstring
 Check if this factory can create widgets for ``algorithm``.
 %End
diff --git a/python/gui/processing/qgsprocessingguiregistry.sip.in b/python/gui/processing/qgsprocessingguiregistry.sip.in
@@ -48,7 +48,7 @@ widgets.
 .. versionadded:: 3.2
 %End
 
-    QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( QgsProcessingAlgorithm *algorithm ) const;
+    QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( const QgsProcessingAlgorithm *algorithm ) const;
 %Docstring
 Get the configuration widget for an ``algorithm``. This widget will be shown
 next to parameter widgets. Most algorithms do not have a configuration widget
diff --git a/src/gui/processing/qgsprocessingalgorithmconfigurationwidget.h b/src/gui/processing/qgsprocessingalgorithmconfigurationwidget.h
@@ -73,12 +73,12 @@ class CORE_EXPORT QgsProcessingAlgorithmConfigurationWidgetFactory
     /**
      * Create a new configuration widget for \a algorithm.
      */
-    virtual QgsProcessingAlgorithmConfigurationWidget *create( QgsProcessingAlgorithm *algorithm ) const = 0 SIP_FACTORY;
+    virtual QgsProcessingAlgorithmConfigurationWidget *create( const QgsProcessingAlgorithm *algorithm ) const = 0 SIP_FACTORY;
 
     /**
      * Check if this factory can create widgets for \a algorithm.
      */
-    virtual bool canCreateFor( QgsProcessingAlgorithm *algorithm ) const = 0;
+    virtual bool canCreateFor( const QgsProcessingAlgorithm *algorithm ) const = 0;
 };
 
 
diff --git a/src/gui/processing/qgsprocessingconfigurationwidgets.cpp b/src/gui/processing/qgsprocessingconfigurationwidgets.cpp
@@ -148,15 +148,15 @@ void QgsFilterAlgorithmConfigurationWidget::addOutput()
   mOutputExpressionWidget->setCellWidget( rowIndex, 2, new QCheckBox() );
 }
 
-QgsProcessingAlgorithmConfigurationWidget *QgsFilterAlgorithmConfigurationWidgetFactory::create( QgsProcessingAlgorithm *algorithm ) const
+QgsProcessingAlgorithmConfigurationWidget *QgsFilterAlgorithmConfigurationWidgetFactory::create( const QgsProcessingAlgorithm *algorithm ) const
 {
   if ( algorithm->name() == QStringLiteral( "filter" ) )
     return new QgsFilterAlgorithmConfigurationWidget();
   else
     return nullptr;
 }
 
-bool QgsFilterAlgorithmConfigurationWidgetFactory::canCreateFor( QgsProcessingAlgorithm *algorithm ) const
+bool QgsFilterAlgorithmConfigurationWidgetFactory::canCreateFor( const QgsProcessingAlgorithm *algorithm ) const
 {
   if ( algorithm->name() == QStringLiteral( "filter" ) )
     return true;
diff --git a/src/gui/processing/qgsprocessingconfigurationwidgets.h b/src/gui/processing/qgsprocessingconfigurationwidgets.h
@@ -50,8 +50,8 @@ class QgsFilterAlgorithmConfigurationWidget : public QgsProcessingAlgorithmConfi
 class QgsFilterAlgorithmConfigurationWidgetFactory : public QgsProcessingAlgorithmConfigurationWidgetFactory
 {
   public:
-    virtual QgsProcessingAlgorithmConfigurationWidget *create( QgsProcessingAlgorithm *algorithm ) const override;
-    virtual bool canCreateFor( QgsProcessingAlgorithm *algorithm ) const override;
+    virtual QgsProcessingAlgorithmConfigurationWidget *create( const QgsProcessingAlgorithm *algorithm ) const override;
+    virtual bool canCreateFor( const QgsProcessingAlgorithm *algorithm ) const override;
 };
 
 ///@endcond
diff --git a/src/gui/processing/qgsprocessingguiregistry.cpp b/src/gui/processing/qgsprocessingguiregistry.cpp
@@ -42,7 +42,7 @@ void QgsProcessingGuiRegistry::removeAlgorithmConfigurationWidgetFactory( QgsPro
   delete factory;
 }
 
-QgsProcessingAlgorithmConfigurationWidget *QgsProcessingGuiRegistry::algorithmConfigurationWidget( QgsProcessingAlgorithm *algorithm ) const
+QgsProcessingAlgorithmConfigurationWidget *QgsProcessingGuiRegistry::algorithmConfigurationWidget( const QgsProcessingAlgorithm *algorithm ) const
 {
   for ( const auto *factory : mAlgorithmConfigurationWidgetFactories )
   {
diff --git a/src/gui/processing/qgsprocessingguiregistry.h b/src/gui/processing/qgsprocessingguiregistry.h
@@ -68,7 +68,7 @@ class GUI_EXPORT QgsProcessingGuiRegistry
      *
      * \since QGIS 3.2
      */
-    QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( QgsProcessingAlgorithm *algorithm ) const;
+    QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( const QgsProcessingAlgorithm *algorithm ) const;
 
   private:
 

Original file line number	Diff line number	Diff line change
`@@ -148,15 +148,15 @@ void QgsFilterAlgorithmConfigurationWidget::addOutput()`
`148`	`148`	`mOutputExpressionWidget->setCellWidget( rowIndex, 2, new QCheckBox() );`
`149`	`149`	`}`
`150`	`150`
`151`		`-QgsProcessingAlgorithmConfigurationWidget QgsFilterAlgorithmConfigurationWidgetFactory::create( QgsProcessingAlgorithm algorithm ) const`
	`151`	`+QgsProcessingAlgorithmConfigurationWidget QgsFilterAlgorithmConfigurationWidgetFactory::create( const QgsProcessingAlgorithm algorithm ) const`
`152`	`152`	`{`
`153`	`153`	`if ( algorithm->name() == QStringLiteral( "filter" ) )`
`154`	`154`	`return new QgsFilterAlgorithmConfigurationWidget();`
`155`	`155`	`else`
`156`	`156`	`return nullptr;`
`157`	`157`	`}`
`158`	`158`
`159`		`-bool QgsFilterAlgorithmConfigurationWidgetFactory::canCreateFor( QgsProcessingAlgorithm *algorithm ) const`
	`159`	`+bool QgsFilterAlgorithmConfigurationWidgetFactory::canCreateFor( const QgsProcessingAlgorithm *algorithm ) const`
`160`	`160`	`{`
`161`	`161`	`if ( algorithm->name() == QStringLiteral( "filter" ) )`
`162`	`162`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ void QgsProcessingGuiRegistry::removeAlgorithmConfigurationWidgetFactory( QgsPro`
`42`	`42`	`delete factory;`
`43`	`43`	`}`
`44`	`44`
`45`		`-QgsProcessingAlgorithmConfigurationWidget QgsProcessingGuiRegistry::algorithmConfigurationWidget( QgsProcessingAlgorithm algorithm ) const`
	`45`	`+QgsProcessingAlgorithmConfigurationWidget QgsProcessingGuiRegistry::algorithmConfigurationWidget( const QgsProcessingAlgorithm algorithm ) const`
`46`	`46`	`{`
`47`	`47`	`for ( const auto *factory : mAlgorithmConfigurationWidgetFactories )`
`48`	`48`	`{`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class GUI_EXPORT QgsProcessingGuiRegistry`
`68`	`68`	`*`
`69`	`69`	`* \since QGIS 3.2`
`70`	`70`	`*/`
`71`		`- QgsProcessingAlgorithmConfigurationWidget algorithmConfigurationWidget( QgsProcessingAlgorithm algorithm ) const;`
	`71`	`+ QgsProcessingAlgorithmConfigurationWidget algorithmConfigurationWidget( const QgsProcessingAlgorithm algorithm ) const;`
`72`	`72`
`73`	`73`	`private:`
`74`	`74`