Code review: using QStringLiteral instead of QString

espinafre · nyalldawson · commit feedcd7ebed9 · 2020-05-10T15:41:37.000+10:00
diff --git a/src/providers/postgres/qgspostgresdataitems.cpp b/src/providers/postgres/qgspostgresdataitems.cpp
@@ -65,7 +65,7 @@ bool QgsPostgresUtils::deleteLayer( const QString &uri, QString &errCause )
   QString type = resViewCheck.PQgetvalue( 0, 0 );
   if ( type == QLatin1String( "v" ) || type == QLatin1String( "m" ) )
   {
-    QString sql = QString( "DROP %1VIEW %2" ).arg( type == QLatin1String( "m" ) ? "MATERIALIZED " : QString(), schemaTableName );
+    QString sql = QStringLiteral( "DROP %1VIEW %2" ).arg( type == QLatin1String( "m" ) ? QStringLiteral( "MATERIALIZED " ) : QString(), schemaTableName );
     QgsPostgresResult result( conn->PQexec( sql ) );
     if ( result.PQresultStatus() != PGRES_COMMAND_OK )
     {

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ bool QgsPostgresUtils::deleteLayer( const QString &uri, QString &errCause )`
`65`	`65`	`QString type = resViewCheck.PQgetvalue( 0, 0 );`
`66`	`66`	`if ( type == QLatin1String( "v" ) \|\| type == QLatin1String( "m" ) )`
`67`	`67`	`{`
`68`		`- QString sql = QString( "DROP %1VIEW %2" ).arg( type == QLatin1String( "m" ) ? "MATERIALIZED " : QString(), schemaTableName );`
	`68`	`+ QString sql = QStringLiteral( "DROP %1VIEW %2" ).arg( type == QLatin1String( "m" ) ? QStringLiteral( "MATERIALIZED " ) : QString(), schemaTableName );`
`69`	`69`	`QgsPostgresResult result( conn->PQexec( sql ) );`
`70`	`70`	`if ( result.PQresultStatus() != PGRES_COMMAND_OK )`
`71`	`71`	`{`