Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Apply suggestions from code review
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
  • Loading branch information
roya0045 and DelazJ committed Jan 11, 2022
1 parent d7ffe0b commit fed4c74
Show file tree
Hide file tree
Showing 21 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion resources/function_help/json/map_get
Expand Up @@ -17,5 +17,5 @@
"expression": "map_get( item_variables('Map 0'), 'map_scale')",
"returns": "scale of the item 'Map 0' (if it exists) in the current print layout"
}],
"tags": ["map", "exist", "key"]
"tags": ["map", "exists", "key"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/max
Expand Up @@ -22,5 +22,5 @@
"expression": "max(20.5,NULL,6.2)",
"returns": "20.5"
}],
"tags": ["longest", "biggest", "most", "largest", "set"]
"tags": ["longest", "biggest", "most", "largest", "maximum"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/max_length
Expand Up @@ -19,5 +19,5 @@
"expression": "max_length(\"town_name\",group_by:=\"state\")",
"returns": "maximum length of town_name, grouped by state field"
}],
"tags": ["length", "field", "maximum", "strings"]
"tags": ["length", "maximum", "strings", "characters", "count", "aggregate"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/maximum
Expand Up @@ -19,5 +19,5 @@
"expression": "maximum(\"population\",group_by:=\"state\")",
"returns": "maximum population value, grouped by state field"
}],
"tags": ["field", "maximum", "aggregate"]
"tags": ["maximum", "aggregate"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/mean
Expand Up @@ -19,5 +19,5 @@
"expression": "mean(\"population\",group_by:=\"state\")",
"returns": "mean population value, grouped by state field"
}],
"tags": ["field", "average", "aggregate", "mean"]
"tags": ["average", "aggregate", "mean"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/median
Expand Up @@ -19,5 +19,5 @@
"expression": "median(\"population\",group_by:=\"state\")",
"returns": "median population value, grouped by state field"
}],
"tags": ["median", "field", "aggregate"]
"tags": ["median", "aggregate"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/min
Expand Up @@ -22,5 +22,5 @@
"expression": "min(2,-10.3,NULL)",
"returns": "-10.3"
}],
"tags": ["least", "smallest", "set"]
"tags": ["least", "smallest", "minimum"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/min_length
Expand Up @@ -19,5 +19,5 @@
"expression": "min_length(\"town_name\",group_by:=\"state\")",
"returns": "minimum length of town_name, grouped by state field"
}],
"tags": ["length", "field", "minimum", "strings"]
"tags": ["length", "characters", "count", "minimum", "strings"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/minimal_circle
Expand Up @@ -19,5 +19,5 @@
"expression": "geom_to_wkt( minimal_circle( geom_from_wkt( 'MULTIPOINT(1 2, 3 4, 3 2)' ), 4 ) )",
"returns": "'Polygon ((3 4, 3 2, 1 2, 1 4, 3 4))'"
}],
"tags": ["enclosing", "minimal", "minimum", "represents", "encloses", "circle", "set"]
"tags": ["enclosing", "minimal", "minimum", "represents", "encloses", "circle", "smallest"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/minimum
Expand Up @@ -19,5 +19,5 @@
"expression": "minimum(\"population\",group_by:=\"state\")",
"returns": "minimum population value, grouped by state field"
}],
"tags": ["field", "minimum", "aggregate"]
"tags": ["minimum", "aggregate"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/nodes_to_points
Expand Up @@ -19,5 +19,5 @@
"expression": "geom_to_wkt(nodes_to_points(geom_from_wkt('POLYGON((-1 -1, 4 0, 4 2, 0 2, -1 -1))'),true))",
"returns": "'MultiPoint ((-1 -1),(4 0),(4 2),(0 2))'"
}],
"tags": ["consisting", "multipoint", "node", "input"]
"tags": ["vertex", "multipoint", "node", "input"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/now
Expand Up @@ -7,5 +7,5 @@
"expression": "now()",
"returns": "2012-07-22T13:24:57"
}],
"tags": ["static", "evaluating", "return", "consistent", "current", "prepared", "date", "time"]
"tags": ["static", "evaluating", "current", "date", "time"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/nullif
Expand Up @@ -20,5 +20,5 @@
"expression": "nullif(\"name\", '')",
"returns": "NULL, if name is an empty string (or already NULL), the name in any other case."
}],
"tags": ["substitute", "equals"]
"tags": ["substitute", "equals", "condition", "compare"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/num_geometries
Expand Up @@ -11,5 +11,5 @@
"expression": "num_geometries(geom_from_wkt('GEOMETRYCOLLECTION(POINT(0 1), POINT(0 0), POINT(1 0), POINT(1 1))'))",
"returns": "4"
}],
"tags": ["collection", "input"]
"tags": ["collection", "multipart", "parts", "count"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/num_interior_rings
Expand Up @@ -11,5 +11,5 @@
"expression": "num_interior_rings(geom_from_wkt('POLYGON((-1 -1, 4 0, 4 2, 0 2, -1 -1),(-0.1 -0.1, 0.4 0, 0.4 0.2, 0 0.2, -0.1 -0.1))'))",
"returns": "1"
}],
"tags": ["rings", "polygon", "input", "collection", "interior"]
"tags": ["rings", "holes", "count", "polygon", "collection", "interior"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/num_rings
Expand Up @@ -11,5 +11,5 @@
"expression": "num_rings(geom_from_wkt('POLYGON((-1 -1, 4 0, 4 2, 0 2, -1 -1),(-0.1 -0.1, 0.4 0, 0.4 0.2, 0 0.2, -0.1 -0.1))'))",
"returns": "2"
}],
"tags": ["rings", "polygon", "input", "collection", "exterior", "including"]
"tags": ["rings", "holes", "polygon", "collection", "exterior", "including"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/oriented_bbox
Expand Up @@ -11,5 +11,5 @@
"expression": "geom_to_wkt( oriented_bbox( geom_from_wkt( 'MULTIPOINT(1 2, 3 4, 3 2)' ) ) )",
"returns": "'Polygon ((3 2, 3 4, 1 4, 1 2, 3 2))'"
}],
"tags": ["oriented", "box", "minimal", "input", "represents", "bounding"]
"tags": ["oriented", "box", "minimal", "represents", "bounding"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/overlaps
Expand Up @@ -17,5 +17,5 @@
"expression": "overlaps( geom_from_wkt( 'LINESTRING(0 0, 1 1)' ), geom_from_wkt( 'LINESTRING(3 3, 4 4, 5 5)' ) )",
"returns": "false"
}],
"tags": ["share", "other", "tests", "contained", "overlaps", "same", "dimension", "space"]
"tags": ["share", "tests", "contained", "overlaps", "same", "dimension", "space"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/parameter
Expand Up @@ -11,5 +11,5 @@
"expression": "parameter('BUFFER_SIZE')",
"returns": "5.6"
}],
"tags": ["algorithm", "parameter", "input", "processing"]
"tags": ["algorithm", "parameter", "processing"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/point_n
Expand Up @@ -14,5 +14,5 @@
"expression": "geom_to_wkt(point_n(geom_from_wkt('POLYGON((0 0, 4 0, 4 2, 0 2, 0 0))'),2))",
"returns": "'Point (4 0)'"
}],
"tags": ["specific", "node"]
"tags": ["specific", "node", "vertex"]
}
2 changes: 1 addition & 1 deletion resources/function_help/json/point_on_surface
Expand Up @@ -11,5 +11,5 @@
"expression": "point_on_surface($geometry)",
"returns": "a point geometry"
}],
"tags": ["point", "surface", "lie", "guaranteed"]
"tags": ["point", "surface", "lie", "centroid"]
}

0 comments on commit fed4c74

Please sign in to comment.