Fix console errors

m-kuhn · m-kuhn · commit fe314754c67e · 2016-04-14T12:15:12.000+02:00
diff --git a/python/console/console.py b/python/console/console.py
@@ -407,9 +407,9 @@ def __init__(self, parent=None):
         }
 
         self.classMenu = QMenu()
-        for (title, icon), commands in default_command.iteritems():
+        for (title, icon), commands in default_command.items():
             action = self.classMenu.addAction(icon, title)
-            action.triggered[()].connect(
+            action.triggered.connect(
                 lambda commands=commands: self.shell.commandConsole(commands))
 
         cM = self.toolBar.widgetForAction(self.actionClass)

-Original file line number
+Diff line change
+        }
         self.classMenu = QMenu()
 -        for (title, icon), commands in default_command.iteritems():
 +        for (title, icon), commands in default_command.items():
             action = self.classMenu.addAction(icon, title)
 -            action.triggered[()].connect(Collapse commentComment on line R412
slarosa commented on Apr 15, 2016 
slarosa
on Apr 15, 2016
Member
@m-kuhn I think that the triggered signal has need of an empty tuple here [()] otherwise it passes a boolean to self.shell.commandConsole and the menu actions will not work.

Any problem to revert this line?
m-kuhn replied on Apr 15, 2016 
m-kuhn
on Apr 15, 2016
MemberAuthor
The console didn't open with PyQt5/Py3 with the extra brackets. I'll have a look if you tell me what I need to do to check if it works correctly.
m-kuhn replied on Apr 15, 2016 
m-kuhn
on Apr 15, 2016
MemberAuthor
I hope 8047a56 solves it. And it adds a test that basically just checks if the code runs error free.
slarosa replied on Apr 15, 2016 
slarosa
on Apr 15, 2016
Member
8047a56 works fine here. thanks
Code has comments. Press enter to view.
 +            action.triggered.connect(
                 lambda commands=commands: self.shell.commandConsole(commands))
         cM = self.toolBar.widgetForAction(self.actionClass)