[Server] WMS GetPrint group layers: use const list

rldhont · nyalldawson · commit fe078c899aed · 2020-05-01T16:23:55.000+10:00
diff --git a/src/server/services/wms/qgswmsrendercontext.cpp b/src/server/services/wms/qgswmsrendercontext.cpp
@@ -289,15 +289,7 @@ bool QgsWmsRenderContext::isValidLayer( const QString &nickname ) const
 
 QList<QgsMapLayer *> QgsWmsRenderContext::layersFromGroup( const QString &nickname ) const
 {
-  QList<QgsMapLayer *> layers;
-  if ( mLayerGroups.contains( nickname ) )
-  {
-    for ( QgsMapLayer *layer : mLayerGroups[nickname] )
-    {
-      layers.append( layer );
-    }
-  }
-  return layers;
+  return mLayerGroups.value( nickname );
 }
 
 bool QgsWmsRenderContext::isValidGroup( const QString &name ) const
diff --git a/src/server/services/wms/qgswmsrenderer.cpp b/src/server/services/wms/qgswmsrenderer.cpp
@@ -620,7 +620,8 @@ namespace QgsWms
             {
               QList<QgsMapLayer *> layersFromGroup;
 
-              for ( QgsMapLayer *layerFromGroup : mContext.layersFromGroup( layer.mNickname ) )
+              const QList<QgsMapLayer *> cLayersFromGroup = mContext.layersFromGroup( layer.mNickname );
+              for ( QgsMapLayer *layerFromGroup : cLayersFromGroup )
               {
 
                 if ( ! layerFromGroup )

Original file line number	Diff line number	Diff line change
`@@ -620,7 +620,8 @@ namespace QgsWms`
`620`	`620`	`{`
`621`	`621`	`QList<QgsMapLayer *> layersFromGroup;`
`622`	`622`
`623`		`- for ( QgsMapLayer *layerFromGroup : mContext.layersFromGroup( layer.mNickname ) )`
	`623`	`+ const QList<QgsMapLayer *> cLayersFromGroup = mContext.layersFromGroup( layer.mNickname );`
	`624`	`+ for ( QgsMapLayer *layerFromGroup : cLayersFromGroup )`
`624`	`625`	`{`
`625`	`626`
`626`	`627`	`if ( ! layerFromGroup )`