Skip to content

Commit

Permalink
Merge pull request #39920 from rouault/wfs_translation
Browse files Browse the repository at this point in the history 
WFS provider: make layer tree view column headers translatable
  • Loading branch information
@rouault
rouault committed Nov 10, 2020
2 parents c97d6d5 + 8a78f8f commit fe05aad
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/providers/wfs/qgswfssourceselect.cpp
View file
Expand Up @@ -97,10 +97,10 @@ QgsWFSSourceSelect::QgsWFSSourceSelect( QWidget *parent, Qt::WindowFlags fl, Qgs
mHoldDialogOpen->setChecked( settings.value( QStringLiteral( "Windows/WFSSourceSelect/HoldDialogOpen" ), false ).toBool() );

mModel = new QStandardItemModel();
mModel->setHorizontalHeaderItem( MODEL_IDX_TITLE, new QStandardItem( QStringLiteral( "Title" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_NAME, new QStandardItem( QStringLiteral( "Name" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_ABSTRACT, new QStandardItem( QStringLiteral( "Abstract" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_SQL, new QStandardItem( QStringLiteral( "Sql" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_TITLE, new QStandardItem( tr( "Title" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_NAME, new QStandardItem( tr( "Name" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_ABSTRACT, new QStandardItem( tr( "Abstract" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_SQL, new QStandardItem( tr( "Sql" ) ) );

mModelProxy = new QSortFilterProxyModel( this );
mModelProxy->setSourceModel( mModel );
Expand Down

2 comments on commit fe05aad

@rduivenvoorde
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouault one of the little things that me bothered in this place is that the WMS is showing Name, Title and WFS is showing Title, Name.
Do you think it is wise to homogenize that (for other W*S dialogs? I think the human readable one (I always forget which one that is, probably Title should be first?

@rouault
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homogenization could be good. Title is supposed to be the human readable one

Please sign in to comment.