Add test for missing vertex check

qgis · Sep 26, 2018 · fd869d8 · fd869d8
1 parent b05ea1a
commit fd869d8
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/tests/src/geometry_checker/testqgsgeometrychecks.cpp b/tests/src/geometry_checker/testqgsgeometrychecks.cpp
@@ -28,6 +28,7 @@
 #include "qgsgeometryfollowboundariescheck.h"
 #include "qgsgeometrygapcheck.h"
 #include "qgsgeometryholecheck.h"
+#include "qgsgeometrymissingvertexcheck.h"
 #include "qgsgeometrylineintersectioncheck.h"
 #include "qgsgeometrylinelayerintersectioncheck.h"
 #include "qgsgeometrymultipartcheck.h"
@@ -81,6 +82,7 @@ class TestQgsGeometryChecks: public QObject
     void testDuplicateNodesCheck();
     void testFollowBoundariesCheck();
     void testGapCheck();
+    void testMissingVertexCheck();
     void testHoleCheck();
     void testLineIntersectionCheck();
     void testLineLayerIntersectionCheck();
@@ -530,6 +532,33 @@ void TestQgsGeometryChecks::testGapCheck()
   cleanupTestContext( context );
 }
 
+void TestQgsGeometryChecks::testMissingVertexCheck()
+{
+  QTemporaryDir dir;
+  QMap<QString, QString> layers;
+  layers.insert( QStringLiteral( "missing_vertex.gpkg" ), QString() );
+  QgsGeometryCheckerContext *context = createTestContext( dir, layers );
+
+  // Test detection
+  QList<QgsGeometryCheckError *> checkErrors;
+  QStringList messages;
+
+  QgsGeometryMissingVertexCheck check( context );
+  check.collectErrors( checkErrors, messages );
+  listErrors( checkErrors, messages );
+
+  const QString layerId = testContext.second.first()->layerId();
+  QVERIFY( searchCheckErrors( checkErrors, layerId, 0, QgsPointXY( 0.251153, -0.460895 ), QgsVertexId() ).size() == 1 );
+  QVERIFY( searchCheckErrors( checkErrors, layerId, 3, QgsPointXY( 0.257985, -0.932886 ), QgsVertexId() ).size() == 1 );
+  QVERIFY( searchCheckErrors( checkErrors, layerId, 5, QgsPointXY( 0.59781, -0.480033 ), QgsVertexId() ).size() == 1 );
+  QVERIFY( searchCheckErrors( checkErrors, layerId, 5, QgsPointXY( 0.605252, -0.664875 ), QgsVertexId() ).size() == 1 );
+  QVERIFY( searchCheckErrors( checkErrors, layerId, 4, QgsPointXY( 0.259197, -0.478311 ), QgsVertexId() ).size() == 1 );
+
+  QCOMPARE( checkErrors.size(), 5 );
+
+  cleanupTestContext( context );
+}
+
 void TestQgsGeometryChecks::testHoleCheck()
 {
   QTemporaryDir dir;

diff --git a/tests/testdata/geometry_checker/missing_vertex.gpkg b/tests/testdata/geometry_checker/missing_vertex.gpkg