Address review

qgis · Jan 26, 2023 · fd242ff · fd242ff
1 parent dcd4afc
commit fd242ff
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/src/plugins/topology/checkDock.cpp b/src/plugins/topology/checkDock.cpp
@@ -400,7 +400,7 @@ void checkDock::runTests( ValidateType type )
     mErrorList << errors;
   }
 
-  for ( TopolError *error : mErrorList )
+  for ( TopolError *error : std::as_const( mErrorList ) )
   {
     if ( !mErrorNames.contains( error->name() ) )
     {

diff --git a/src/plugins/topology/dockModel.cpp b/src/plugins/topology/dockModel.cpp
@@ -135,17 +135,13 @@ void DockModel::reload( const QModelIndex &index1, const QModelIndex &index2 )
 }
 
 DockFilterModel::DockFilterModel( ErrorList &errorList, QObject *parent = nullptr )
-  : mDockModel( new DockModel( errorList, parent ) )
+  : QSortFilterProxyModel( parent )
+  , mDockModel( new DockModel( errorList, parent ) )
 {
   setSourceModel( mDockModel );
   setFilterKeyColumn( 0 );
 }
 
-DockFilterModel::~DockFilterModel()
-{
-  mDockModel->deleteLater();
-}
-
 void DockFilterModel::reload( const QModelIndex &index1, const QModelIndex &index2 )
 {
   mDockModel->reload( index1, index2 );

diff --git a/src/plugins/topology/dockModel.h b/src/plugins/topology/dockModel.h
@@ -109,7 +109,7 @@ class DockFilterModel : public QSortFilterProxyModel
      */
     DockFilterModel( ErrorList &errorList, QObject *parent );
 
-    ~DockFilterModel();
+    ~DockFilterModel() = default;
 
     /**
      * Reloads the model data between indices

diff --git a/src/plugins/topology/rulesDialog.cpp b/src/plugins/topology/rulesDialog.cpp
@@ -267,8 +267,8 @@ void rulesDialog::addRule()
 void rulesDialog::deleteTest()
 {
   std::set<int, std::greater<int>> selectedRows;
-  QModelIndexList selectedIndexes = mRulesTable->selectionModel()->selectedRows();
-  for ( QModelIndex index : selectedIndexes )
+  const QModelIndexList selectedIndexes = mRulesTable->selectionModel()->selectedRows();
+  for ( const QModelIndex index : selectedIndexes )
   {
     selectedRows.insert( index.row() );
   }