Fix splitFeatures

m-kuhn · m-kuhn · commit fca603caa311 · 2017-08-14T12:59:40.000+02:00
diff --git a/src/core/qgsvectorlayereditutils.cpp b/src/core/qgsvectorlayereditutils.cpp
@@ -277,7 +277,6 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QList
   if ( !mLayer->isSpatial() )
     return QgsGeometry::InvalidBaseGeometry;
 
-  QgsFeatureList newFeatures; //store all the newly created features
   double xMin, yMin, xMax, yMax;
   QgsRectangle bBox; //bounding box of the split line
   QgsGeometry::OperationResult returnCode = QgsGeometry::Success;
@@ -293,7 +292,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QList
   }
   else //else consider all the feature that intersect the bounding box of the split line
   {
-    if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) == 0 )
+    if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) )
     {
       bBox.setXMinimum( xMin );
       bBox.setYMinimum( yMin );
@@ -402,7 +401,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitParts( const QList<Qg
   }
   else //else consider all the feature that intersect the bounding box of the split line
   {
-    if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) == 0 )
+    if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) )
     {
       bBox.setXMinimum( xMin );
       bBox.setYMinimum( yMin );

Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,6 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QList`
`277`	`277`	`if ( !mLayer->isSpatial() )`
`278`	`278`	`return QgsGeometry::InvalidBaseGeometry;`
`279`	`279`
`280`		`- QgsFeatureList newFeatures; //store all the newly created features`
`281`	`280`	`double xMin, yMin, xMax, yMax;`
`282`	`281`	`QgsRectangle bBox; //bounding box of the split line`
`283`	`282`	`QgsGeometry::OperationResult returnCode = QgsGeometry::Success;`
`@@ -293,7 +292,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QList`
`293`	`292`	`}`
`294`	`293`	`else //else consider all the feature that intersect the bounding box of the split line`
`295`	`294`	`{`
`296`		`- if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) == 0 )`
	`295`	`+ if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) )`
`297`	`296`	`{`
`298`	`297`	`bBox.setXMinimum( xMin );`
`299`	`298`	`bBox.setYMinimum( yMin );`
`@@ -402,7 +401,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitParts( const QList<Qg`
`402`	`401`	`}`
`403`	`402`	`else //else consider all the feature that intersect the bounding box of the split line`
`404`	`403`	`{`
`405`		`- if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) == 0 )`
	`404`	`+ if ( boundingBoxFromPointList( splitLine, xMin, yMin, xMax, yMax ) )`
`406`	`405`	`{`
`407`	`406`	`bBox.setXMinimum( xMin );`
`408`	`407`	`bBox.setYMinimum( yMin );`