Skip to content

Commit

Permalink
vector file writer: reapply integer options (accidentally removed in 9…
Browse files Browse the repository at this point in the history 
…a6235d; fixes #16811, #16819)
  • Loading branch information
@jef-n
jef-n committed Jul 13, 2017
1 parent a2b82bf commit fc7ac83
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/gui/ogr/qgsvectorlayersaveasdialog.cpp
View file
Expand Up @@ -744,7 +744,8 @@ QStringList QgsVectorLayerSaveAsDialog::layerOptions() const
QgsVectorFileWriter::IntOption *opt = dynamic_cast<QgsVectorFileWriter::IntOption *>( *it );
QSpinBox *sb = mLayerOptionsGroupBox->findChild<QSpinBox *>( it.key() );
if ( opt && sb && sb->value() != opt->defaultValue )
break;
options << QStringLiteral( "%1=%2" ).arg( it.key() ).arg( sb->value() );
break;
}

case QgsVectorFileWriter::Set:
Expand Down

6 comments on commit fc7ac83

@gioman
Copy link
Contributor

@gioman gioman commented on fc7ac83 Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef-n was this backported to 2.18?

@jef-n
Copy link
Member Author

@jef-n jef-n commented on fc7ac83 Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 2.18 was not affected by this. See 9a6235d#commitcomment-23071479

@gioman
Copy link
Contributor

@gioman gioman commented on fc7ac83 Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 2.18 was not affected by this. See 9a6235d#commitcomment-23071479

sorry, 2.18.10/11 are very much affected by this.

@jef-n
Copy link
Member Author

@jef-n jef-n commented on fc7ac83 Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said the line re-added in this commit wasn't removed from 2.18 - so it can't possibly affect 2.18.

@gioman
Copy link
Contributor

@gioman gioman commented on fc7ac83 Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef ok ill try to be more precise: issues #16811 and #16819 were reported against 2.18.10 as regressions from 2.18.9 so this commit could not possibly close them, so they were reopened and the issues still affect 2.18.11

@jef-n
Copy link
Member Author

@jef-n jef-n commented on fc7ac83 Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gioman no need to get more precise here - and the comment referenced above already confirms that it's not a fix.

Please sign in to comment.