Skip to content

Commit fc7ac83

Browse files
committedJul 13, 2017
vector file writer: reapply integer options (accidentally removed in 9a6235d; fixes #16811, #16819)
1 parent a2b82bf commit fc7ac83

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed
 

‎src/gui/ogr/qgsvectorlayersaveasdialog.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,8 @@ QStringList QgsVectorLayerSaveAsDialog::layerOptions() const
744744
QgsVectorFileWriter::IntOption *opt = dynamic_cast<QgsVectorFileWriter::IntOption *>( *it );
745745
QSpinBox *sb = mLayerOptionsGroupBox->findChild<QSpinBox *>( it.key() );
746746
if ( opt && sb && sb->value() != opt->defaultValue )
747-
break;
747+
options << QStringLiteral( "%1=%2" ).arg( it.key() ).arg( sb->value() );
748+
break;
748749
}
749750

750751
case QgsVectorFileWriter::Set:

6 commit comments

Comments
 (6)

gioman commented on Jul 24, 2017

@gioman
Contributor

@jef-n was this backported to 2.18?

jef-n commented on Jul 24, 2017

@jef-n
MemberAuthor

No, 2.18 was not affected by this. See 9a6235d#commitcomment-23071479

gioman commented on Jul 24, 2017

@gioman
Contributor

No, 2.18 was not affected by this. See 9a6235d#commitcomment-23071479

sorry, 2.18.10/11 are very much affected by this.

jef-n commented on Jul 24, 2017

@jef-n
MemberAuthor

As said the line re-added in this commit wasn't removed from 2.18 - so it can't possibly affect 2.18.

gioman commented on Jul 24, 2017

@gioman
Contributor

@jef ok ill try to be more precise: issues #16811 and #16819 were reported against 2.18.10 as regressions from 2.18.9 so this commit could not possibly close them, so they were reopened and the issues still affect 2.18.11

jef-n commented on Jul 24, 2017

@jef-n
MemberAuthor

@gioman no need to get more precise here - and the comment referenced above already confirms that it's not a fix.

Please sign in to comment.