Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[attributetable] Usability improvements for filters
  • Loading branch information
m-kuhn committed Apr 18, 2013
1 parent 01e26da commit fc715d9
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
13 changes: 11 additions & 2 deletions src/app/qgsattributetabledialog.cpp
Expand Up @@ -229,11 +229,14 @@ void QgsAttributeTableDialog::columnBoxInit()
}

mFilterButton->addAction( mActionShowAllFilter );
mFilterButton->addAction( mActionAdvancedFilter );
mFilterButton->addAction( mActionSelectedFilter );
mFilterButton->addAction( mActionVisibleFilter );
if ( mLayer->hasGeometryType() )
{
mFilterButton->addAction( mActionVisibleFilter );
}
mFilterButton->addAction( mActionEditedFilter );
mFilterButton->addAction( mActionFilterColumnsMenu );
mFilterButton->addAction( mActionAdvancedFilter );

QList<QgsField> fields = mLayer->pendingFields().toList();

Expand Down Expand Up @@ -309,6 +312,12 @@ void QgsAttributeTableDialog::filterSelected()

void QgsAttributeTableDialog::filterVisible()
{
if ( !mLayer->hasGeometryType() )
{
filterShowAll();
return;
}

mFilterButton->setDefaultAction( mActionVisibleFilter );
mFilterButton->setPopupMode( QToolButton::InstantPopup );
mCbxCaseSensitive->setVisible( false );
Expand Down
1 change: 1 addition & 0 deletions src/gui/attributetable/qgsattributetablefiltermodel.cpp
Expand Up @@ -223,6 +223,7 @@ void QgsAttributeTableFilterModel::generateListOfVisibleFeatures()
if ( !renderer )
{
QgsDebugMsg( "Cannot get renderer" );
return;
}

if ( layer()->hasScaleBasedVisibility() &&
Expand Down
6 changes: 3 additions & 3 deletions src/ui/qgsattributetabledialog.ui
Expand Up @@ -557,7 +557,7 @@
<normaloff>:/images/themes/default/mActionFilter.png</normaloff>:/images/themes/default/mActionFilter.png</iconset>
</property>
<property name="text">
<string>Show All</string>
<string>Show All Features</string>
</property>
</action>
<action name="mActionSelectedFilter">
Expand All @@ -566,7 +566,7 @@
<normaloff>:/images/themes/default/mActionFilter.png</normaloff>:/images/themes/default/mActionFilter.png</iconset>
</property>
<property name="text">
<string>Show Selected</string>
<string>Show Selected Features</string>
</property>
</action>
<action name="mActionVisibleFilter">
Expand All @@ -589,7 +589,7 @@
<normaloff>:/images/themes/default/mActionFilter.png</normaloff>:/images/themes/default/mActionFilter.png</iconset>
</property>
<property name="text">
<string>Filter Edited</string>
<string>Show Edited and New Features</string>
</property>
<property name="toolTip">
<string>Filter all the features which have been edited but not yet saved</string>
Expand Down

0 comments on commit fc715d9

Please sign in to comment.