Merge pull request #6791 from m-kuhn/fixwarnings

m-kuhn · web-flow · commit fc704efbf2c0 · 2018-04-16T14:20:51.000+02:00
Fix some build warnings
diff --git a/python/gui/editorwidgets/core/qgseditorwidgetautoconf.sip.in b/python/gui/editorwidgets/core/qgseditorwidgetautoconf.sip.in
@@ -20,6 +20,7 @@ Base class for plugins allowing to pick automatically a widget type for editing
 #include "qgseditorwidgetautoconf.h"
 %End
   public:
+    virtual ~QgsEditorWidgetAutoConfPlugin();
 
     virtual QgsEditorWidgetSetup editorWidgetSetup( const QgsVectorLayer *vl, const QString &fieldName, int &score /Out/ ) const = 0;
 %Docstring
diff --git a/src/core/qgserror.h b/src/core/qgserror.h
@@ -69,9 +69,6 @@ class CORE_EXPORT QgsErrorMessage
     QString mFile;
     QString mFunction;
     int mLine = 0;
-
-    //! Message format
-    Format mFormat = Text;
 };
 
 /**
diff --git a/src/core/raster/qgsrasterfilewriter.cpp b/src/core/raster/qgsrasterfilewriter.cpp
@@ -497,7 +497,6 @@ QgsRasterFileWriter::WriterError QgsRasterFileWriter::writeImageRaster( QgsRaste
   void *greenData = qgsMalloc( mMaxTileWidth * mMaxTileHeight );
   void *blueData = qgsMalloc( mMaxTileWidth * mMaxTileHeight );
   void *alphaData = qgsMalloc( mMaxTileWidth * mMaxTileHeight );
-  QgsRectangle mapRect;
   int iterLeft = 0, iterTop = 0, iterCols = 0, iterRows = 0;
   int fileIndex = 0;
 
diff --git a/src/core/symbology/qgssymbollayerutils.cpp b/src/core/symbology/qgssymbollayerutils.cpp
@@ -1477,7 +1477,7 @@ bool QgsSymbolLayerUtils::convertPolygonSymbolizerToPointMarker( QDomElement &el
     int markIndex = -1;
     QColor fillColor, strokeColor;
     double strokeWidth = 1.0, size = 0.0, angle = 0.0;
-    QPointF anchor, offset;
+    QPointF offset;
 
     // Fill element can contain a GraphicFill element
     QDomElement graphicFillElem = fillElem.firstChildElement( QStringLiteral( "GraphicFill" ) );
diff --git a/src/gui/editorwidgets/core/qgseditorwidgetautoconf.h b/src/gui/editorwidgets/core/qgseditorwidgetautoconf.h
@@ -32,6 +32,7 @@ class QgsEditorWidgetSetup;
 class GUI_EXPORT QgsEditorWidgetAutoConfPlugin
 {
   public:
+    virtual ~QgsEditorWidgetAutoConfPlugin() = default;
 
     /**
      * Typical scores are:
diff --git a/src/providers/gpx/qgsgpxprovider.cpp b/src/providers/gpx/qgsgpxprovider.cpp
@@ -216,7 +216,6 @@ bool QgsGPXProvider::addFeature( QgsFeature &f, Flags )
   bool success = false;
   QgsGpsObject *obj = nullptr;
   QgsAttributes attrs = f.attributes();
-  QgsAttributeMap::const_iterator it;
 
   // is it a waypoint?
   if ( mFeatureType == WaypointType && geo && wkbType == QgsWkbTypes::Point )

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ class QgsEditorWidgetSetup;`
`32`	`32`	`class GUI_EXPORT QgsEditorWidgetAutoConfPlugin`
`33`	`33`	`{`
`34`	`34`	`public:`
	`35`	`+ virtual ~QgsEditorWidgetAutoConfPlugin() = default;`
`35`	`36`
`36`	`37`	`/**`
`37`	`38`	`* Typical scores are:`