Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Remove conversions.sip conditionals meant for 4.12 but actually 4.18
- The hex version of 4.12 was not 0x041200 (current 4.18) but 0x040c00. Code was always skipped and has worked with recent sip versions.
- Loading branch information
Showing
1 changed file
with
0 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc6559a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dakcarto should this be backported?
fc6559a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is now. Wanted to wait for a build or two across platforms before backporting, since I only tested on Mac.
fc6559a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll include this change in the qgis Debian package to resolve Debian Bug #822477, it's unfortunate that this change didn't make it into todays 2.14.2 release. I look forward to dropping the patch for update to 2.14.3.
fc6559a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about 8dcd918?
fc6559a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.