Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move addFeature, startEditing and stopEditing vector layer actions
to an abstract base class QgsVectorLayerTools in the gui library, so these can be reimplemented for a custom app, but can also be used from plugins or in the gui library.
- Loading branch information
Showing
14 changed files
with
372 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| class QgsVectorLayerTools | ||
| { | ||
| %TypeHeaderCode | ||
| #include <qgsvectorlayertools.h> | ||
| %End | ||
| public: | ||
| virtual bool addFeature( QgsVectorLayer* layer, QgsAttributeMap defaultValues = QgsAttributeMap(), const QgsGeometry& = QgsGeometry() ) = 0; | ||
| virtual bool startEditing( QgsVectorLayer* layer ) = 0; | ||
| virtual bool stopEditing( QgsVectorLayer* layer, bool allowCancel = true ) = 0; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| /*************************************************************************** | ||
| qgsfeaturefactory.cpp | ||
| -------------------------------------- | ||
| Date : 30.5.2013 | ||
| Copyright : (C) 2013 Matthias Kuhn | ||
| Email : matthias dot kuhn at gmx dot ch | ||
| *************************************************************************** | ||
| * * | ||
| * This program is free software; you can redistribute it and/or modify * | ||
| * it under the terms of the GNU General Public License as published by * | ||
| * the Free Software Foundation; either version 2 of the License, or * | ||
| * (at your option) any later version. * | ||
| * * | ||
| ***************************************************************************/ | ||
|
|
||
| #include <QMessageBox> | ||
| #include <QToolButton> | ||
|
|
||
| #include "qgsguivectorlayertools.h" | ||
| #include "qgsvectorlayer.h" | ||
| #include "qgsvectordataprovider.h" | ||
| #include "qgsmessagebar.h" | ||
| #include "qgisapp.h" | ||
| #include "qgsapplication.h" | ||
| #include "qgsmessageviewer.h" | ||
| #include "qgsfeatureaction.h" | ||
| #include "qgsmapcanvas.h" | ||
| #include "qgsmessagebaritem.h" | ||
|
|
||
|
|
||
| QgsGuiVectorLayerTools::QgsGuiVectorLayerTools() | ||
| : QObject( NULL ) | ||
| {} | ||
|
|
||
| bool QgsGuiVectorLayerTools::addFeature( QgsVectorLayer* layer, QgsAttributeMap defaultValues, const QgsGeometry& defaultGeometry ) | ||
| { | ||
| QgsFeature f; | ||
| f.setGeometry( defaultGeometry ); | ||
| QgsFeatureAction a( tr( "Add feature" ), f, layer ); | ||
| return a.addFeature( defaultValues ); | ||
| } | ||
|
|
||
| bool QgsGuiVectorLayerTools::startEditing( QgsVectorLayer* layer ) | ||
| { | ||
| if ( !layer ) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| bool res = true; | ||
|
|
||
| if ( !layer->isEditable() && !layer->isReadOnly() ) | ||
| { | ||
| if ( !( layer->dataProvider()->capabilities() & QgsVectorDataProvider::EditingCapabilities ) ) | ||
| { | ||
| QgisApp::instance()->messageBar()->pushMessage( tr( "Start editing failed" ), | ||
| tr( "Provider cannot be opened for editing" ), | ||
| QgsMessageBar::INFO, QgisApp::instance()->messageTimeout() ); | ||
| return false; | ||
| } | ||
|
|
||
| layer->startEditing(); | ||
| } | ||
|
|
||
| return res; | ||
| } | ||
|
|
||
| bool QgsGuiVectorLayerTools::stopEditing( QgsVectorLayer* layer, bool allowCancel ) | ||
| { | ||
| bool res = true; | ||
|
|
||
| if ( layer->isModified() ) | ||
| { | ||
| QMessageBox::StandardButtons buttons = QMessageBox::Save | QMessageBox::Discard; | ||
| if ( allowCancel ) | ||
| buttons |= QMessageBox::Cancel; | ||
|
|
||
| switch ( QMessageBox::information( 0, | ||
| tr( "Stop editing" ), | ||
| tr( "Do you want to save the changes to layer %1?" ).arg( layer->name() ), | ||
| buttons ) ) | ||
| { | ||
| case QMessageBox::Cancel: | ||
| res = false; | ||
| break; | ||
|
|
||
| case QMessageBox::Save: | ||
| if ( !layer->commitChanges() ) | ||
| { | ||
| commitError( layer ); | ||
| // Leave the in-memory editing state alone, | ||
| // to give the user a chance to enter different values | ||
| // and try the commit again later | ||
| res = false; | ||
| } | ||
|
|
||
| layer->triggerRepaint(); | ||
| break; | ||
|
|
||
| case QMessageBox::Discard: | ||
| QgisApp::instance()->mapCanvas()->freeze( true ); | ||
| if ( !layer->rollBack() ) | ||
| { | ||
| QgisApp::instance()->messageBar()->pushMessage( tr( "Error" ), | ||
| tr( "Problems during roll back" ), | ||
| QgsMessageBar::CRITICAL ); | ||
| res = false; | ||
| } | ||
| QgisApp::instance()->mapCanvas()->freeze( false ); | ||
|
|
||
| layer->triggerRepaint(); | ||
| break; | ||
|
|
||
| default: | ||
| break; | ||
| } | ||
| } | ||
| else //layer not modified | ||
| { | ||
| QgisApp::instance()->mapCanvas()->freeze( true ); | ||
| layer->rollBack(); | ||
| QgisApp::instance()->mapCanvas()->freeze( false ); | ||
| res = true; | ||
| layer->triggerRepaint(); | ||
| } | ||
|
|
||
| return res; | ||
| } | ||
|
|
||
| void QgsGuiVectorLayerTools::commitError( QgsVectorLayer* vlayer ) | ||
| { | ||
| QgsMessageViewer *mv = new QgsMessageViewer(); | ||
| mv->setWindowTitle( tr( "Commit errors" ) ); | ||
| mv->setMessageAsPlainText( tr( "Could not commit changes to layer %1" ).arg( vlayer->name() ) | ||
| + "\n\n" | ||
| + tr( "Errors: %1\n" ).arg( vlayer->commitErrors().join( "\n " ) ) | ||
| ); | ||
|
|
||
| QToolButton *showMore = new QToolButton(); | ||
| // store pointer to vlayer in data of QAction | ||
| QAction *act = new QAction( showMore ); | ||
| act->setData( QVariant( QMetaType::QObjectStar, &vlayer ) ); | ||
| act->setText( tr( "Show more" ) ); | ||
| showMore->setStyleSheet( "background-color: rgba(255, 255, 255, 0); color: black; text-decoration: underline;" ); | ||
| showMore->setCursor( Qt::PointingHandCursor ); | ||
| showMore->setSizePolicy( QSizePolicy::Maximum, QSizePolicy::Preferred ); | ||
| showMore->addAction( act ); | ||
| showMore->setDefaultAction( act ); | ||
| connect( showMore, SIGNAL( triggered( QAction* ) ), mv, SLOT( exec() ) ); | ||
| connect( showMore, SIGNAL( triggered( QAction* ) ), showMore, SLOT( deleteLater() ) ); | ||
|
|
||
| // no timeout set, since notice needs attention and is only shown first time layer is labeled | ||
| QgsMessageBarItem *errorMsg = new QgsMessageBarItem( | ||
| tr( "Commit errors" ), | ||
| tr( "Could not commit changes to layer %1" ).arg( vlayer->name() ), | ||
| showMore, | ||
| QgsMessageBar::WARNING, | ||
| 0, | ||
| QgisApp::instance()->messageBar() ); | ||
| QgisApp::instance()->messageBar()->pushItem( errorMsg ); | ||
|
|
||
| } |
Oops, something went wrong.