[mssql] For consistency with other providers deleteFeatures should return true to an empty list

nyalldawson · nyalldawson · commit fb0b8fdadc6a · 2018-10-26T07:54:14.000+10:00
diff --git a/src/providers/mssql/qgsmssqlprovider.cpp b/src/providers/mssql/qgsmssqlprovider.cpp
@@ -1385,6 +1385,9 @@ bool QgsMssqlProvider::deleteFeatures( const QgsFeatureIds &id )
   if ( mFidColName.isEmpty() )
     return false;
 
+  if ( id.empty() )
+    return true; // for consistency providers return true to an empty list
+
   QString featureIds;
   for ( QgsFeatureIds::const_iterator it = id.begin(); it != id.end(); ++it )
   {

Original file line number	Diff line number	Diff line change
`@@ -1385,6 +1385,9 @@ bool QgsMssqlProvider::deleteFeatures( const QgsFeatureIds &id )`
`1385`	`1385`	`if ( mFidColName.isEmpty() )`
`1386`	`1386`	`return false;`
`1387`	`1387`
	`1388`	`+ if ( id.empty() )`
	`1389`	`+ return true; // for consistency providers return true to an empty list`
	`1390`	`+`
`1388`	`1391`	`QString featureIds;`
`1389`	`1392`	`for ( QgsFeatureIds::const_iterator it = id.begin(); it != id.end(); ++it )`
`1390`	`1393`	`{`