[Plugins] disable plugins which crash on load

m-kuhn · m-kuhn · commit fa40e78f6083 · 2016-02-15T10:23:39.000+01:00
diff --git a/python/pyplugin_installer/installer.py b/python/pyplugin_installer/installer.py
@@ -91,8 +91,10 @@ def __init__(self):
                 updateAvailablePlugins()
                 settings = QSettings()
                 if settings.value("/PythonPlugins/" + key, False, type=bool):
+                    settings.setValue("/PythonPlugins/watchDog/" + key, True)
                     loadPlugin(key)
                     startPlugin(key)
+                    settings.remove("/PythonPlugins/watchDog/" + key)
 
     # ----------------------------------------- #
     def fetchAvailablePlugins(self, reloadMode):
diff --git a/python/pyplugin_installer/installer_data.py b/python/pyplugin_installer/installer_data.py
@@ -696,7 +696,8 @@ def getAllInstalled(self, testLoad=True):
                         # readOnly = not QFileInfo(pluginsPath).isWritable() # On windows testing the writable status isn't reliable.
                         readOnly = isTheSystemDir                            # Assume only the system plugins are not writable.
                         # only test those not yet loaded. Loaded plugins already proved they're o.k.
-                        testLoadThis = testLoad and key not in qgis.utils.plugins
+                        failedToLoad = settings.value("/PythonPlugins/watchDog/" + key) is not None
+                        testLoadThis = testLoad and key not in qgis.utils.plugins and not failedToLoad
                         plugin = self.getInstalledPlugin(key, path=path, readOnly=readOnly, testLoad=testLoadThis)
                         self.localCache[key] = plugin
                         if key in self.localCache.keys() and compareVersions(self.localCache[key]["version_installed"], plugin["version_installed"]) == 1:
diff --git a/src/app/qgspluginregistry.cpp b/src/app/qgspluginregistry.cpp
@@ -469,9 +469,16 @@ void QgsPluginRegistry::restoreSessionPlugins( const QString& thePluginDirString
       // check if the plugin was active on last session
 
       QString baseName = QFileInfo( myFullPath ).baseName();
+      if ( mySettings.value( QString( "/Plugins/watchDog/%1" ).arg( baseName ) ).isValid() )
+      {
+        mQgisInterface->messageBar()->pushWarning( QObject::tr( "Plugin %1" ).arg( baseName ), QObject::tr( "The plugin will be disabled because it crashed QGIS during last startup. Please report an issue and re-enable the plugin when the problem has been solved." ) );
+        mySettings.setValue( "/Plugins/" + baseName, false );
+      }
       if ( mySettings.value( "/Plugins/" + baseName ).toBool() )
       {
+        mySettings.setValue( QString( "/Plugins/watchDog/%1" ).arg( baseName ), true );
         loadCppPlugin( myFullPath );
+        mySettings.remove( QString( "/Plugins/watchDog/%1" ).arg( baseName ) );
       }
     }
   }
@@ -490,18 +497,16 @@ void QgsPluginRegistry::restoreSessionPlugins( const QString& thePluginDirString
     corePlugins << "MetaSearch";
 
     // make the required core plugins enabled by default:
-    for ( int i = 0; i < corePlugins.size(); i++ )
+    Q_FOREACH ( const QString& corePlugin, corePlugins )
     {
-      if ( !mySettings.contains( "/PythonPlugins/" + corePlugins[i] ) )
+      if ( !mySettings.contains( "/PythonPlugins/" + corePlugin ) )
       {
-        mySettings.setValue( "/PythonPlugins/" + corePlugins[i], true );
+        mySettings.setValue( "/PythonPlugins/" + corePlugin, true );
       }
     }
 
-    for ( int i = 0; i < pluginList.size(); i++ )
+    Q_FOREACH ( const QString& packageName, pluginList )
     {
-      QString packageName = pluginList[i];
-
       // TODO: apply better solution for #5879
       // start - temporary fix for issue #5879
       if ( QgsApplication::isRunningFromBuildDir() )
@@ -517,14 +522,22 @@ void QgsPluginRegistry::restoreSessionPlugins( const QString& thePluginDirString
       }
       // end - temporary fix for issue #5879, more below
 
-      if ( checkPythonPlugin( packageName ) )
-      {
-        // check if the plugin was active on last session
 
-        if ( mySettings.value( "/PythonPlugins/" + packageName ).toBool() )
+      if ( mySettings.value( "/PythonPlugins/watchDog/" + packageName ).isValid() )
+      {
+        mQgisInterface->messageBar()->pushWarning( "Plugin " + packageName, "The plugin will be disabled because it crashed QGIS during last startup. Please report an issue and re-enable the plugin when the problem has been solved." );
+        mySettings.setValue( "/PythonPlugins/" + packageName, false );
+      }
+      // check if the plugin was active on last session
+      if ( mySettings.value( "/PythonPlugins/" + packageName ).toBool() )
+      {
+        mySettings.setValue( "/PythonPlugins/watchDog/" + packageName, true );
+        if ( checkPythonPlugin( packageName ) )
         {
           loadPythonPlugin( packageName );
         }
+        mySettings.remove( "/PythonPlugins/watchDog/" + packageName );
+
       }
     }
     // start - temporary fix for issue #5879, more above

Original file line number	Diff line number	Diff line change
`@@ -469,9 +469,16 @@ void QgsPluginRegistry::restoreSessionPlugins( const QString& thePluginDirString`
`469`	`469`	`// check if the plugin was active on last session`
`470`	`470`
`471`	`471`	`QString baseName = QFileInfo( myFullPath ).baseName();`
	`472`	`+ if ( mySettings.value( QString( "/Plugins/watchDog/%1" ).arg( baseName ) ).isValid() )`
	`473`	`+ {`
	`474`	`+ mQgisInterface->messageBar()->pushWarning( QObject::tr( "Plugin %1" ).arg( baseName ), QObject::tr( "The plugin will be disabled because it crashed QGIS during last startup. Please report an issue and re-enable the plugin when the problem has been solved." ) );`
	`475`	`+ mySettings.setValue( "/Plugins/" + baseName, false );`
	`476`	`+ }`
`472`	`477`	`if ( mySettings.value( "/Plugins/" + baseName ).toBool() )`
`473`	`478`	`{`
	`479`	`+ mySettings.setValue( QString( "/Plugins/watchDog/%1" ).arg( baseName ), true );`
`474`	`480`	`loadCppPlugin( myFullPath );`
	`481`	`+ mySettings.remove( QString( "/Plugins/watchDog/%1" ).arg( baseName ) );`
`475`	`482`	`}`
`476`	`483`	`}`
`477`	`484`	`}`
`@@ -490,18 +497,16 @@ void QgsPluginRegistry::restoreSessionPlugins( const QString& thePluginDirString`
`490`	`497`	`corePlugins << "MetaSearch";`
`491`	`498`
`492`	`499`	`// make the required core plugins enabled by default:`
`493`		`- for ( int i = 0; i < corePlugins.size(); i++ )`
	`500`	`+ Q_FOREACH ( const QString& corePlugin, corePlugins )`
`494`	`501`	`{`
`495`		`- if ( !mySettings.contains( "/PythonPlugins/" + corePlugins[i] ) )`
	`502`	`+ if ( !mySettings.contains( "/PythonPlugins/" + corePlugin ) )`
`496`	`503`	`{`
`497`		`- mySettings.setValue( "/PythonPlugins/" + corePlugins[i], true );`
	`504`	`+ mySettings.setValue( "/PythonPlugins/" + corePlugin, true );`
`498`	`505`	`}`
`499`	`506`	`}`
`500`	`507`
`501`		`- for ( int i = 0; i < pluginList.size(); i++ )`
	`508`	`+ Q_FOREACH ( const QString& packageName, pluginList )`
`502`	`509`	`{`
`503`		`- QString packageName = pluginList[i];`
`504`		`-`
`505`	`510`	`// TODO: apply better solution for #5879`
`506`	`511`	`// start - temporary fix for issue #5879`
`507`	`512`	`if ( QgsApplication::isRunningFromBuildDir() )`
`@@ -517,14 +522,22 @@ void QgsPluginRegistry::restoreSessionPlugins( const QString& thePluginDirString`
`517`	`522`	`}`
`518`	`523`	`// end - temporary fix for issue #5879, more below`
`519`	`524`
`520`		`- if ( checkPythonPlugin( packageName ) )`
`521`		`- {`
`522`		`- // check if the plugin was active on last session`
`523`	`525`
`524`		`- if ( mySettings.value( "/PythonPlugins/" + packageName ).toBool() )`
	`526`	`+ if ( mySettings.value( "/PythonPlugins/watchDog/" + packageName ).isValid() )`
	`527`	`+ {`
	`528`	`+ mQgisInterface->messageBar()->pushWarning( "Plugin " + packageName, "The plugin will be disabled because it crashed QGIS during last startup. Please report an issue and re-enable the plugin when the problem has been solved." );`
	`529`	`+ mySettings.setValue( "/PythonPlugins/" + packageName, false );`
	`530`	`+ }`
	`531`	`+ // check if the plugin was active on last session`
	`532`	`+ if ( mySettings.value( "/PythonPlugins/" + packageName ).toBool() )`
	`533`	`+ {`
	`534`	`+ mySettings.setValue( "/PythonPlugins/watchDog/" + packageName, true );`
	`535`	`+ if ( checkPythonPlugin( packageName ) )`
`525`	`536`	`{`
`526`	`537`	`loadPythonPlugin( packageName );`
`527`	`538`	`}`
	`539`	`+ mySettings.remove( "/PythonPlugins/watchDog/" + packageName );`
	`540`	`+`
`528`	`541`	`}`
`529`	`542`	`}`
`530`	`543`	`// start - temporary fix for issue #5879, more above`