Fix memory leak, potential crash when creating QgsVectorLayerSimpleLa…

…beling Identified by Coverity
qgis · May 29, 2017 · fa3e014 · fa3e014
1 parent fb76383
commit fa3e014
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/core/qgsvectorlayerlabeling.cpp b/src/core/qgsvectorlayerlabeling.cpp
@@ -78,13 +78,13 @@ bool QgsVectorLayerSimpleLabeling::requiresAdvancedEffects() const
 
 QgsVectorLayerSimpleLabeling *QgsVectorLayerSimpleLabeling::create( const QDomElement &element, const QgsReadWriteContext &context )
 {
-  QgsPalLayerSettings *settings = nullptr;
   QDomElement settingsElem = element.firstChildElement( QStringLiteral( "settings" ) );
   if ( !settingsElem.isNull() )
   {
-    settings = new QgsPalLayerSettings;
-    settings->readXml( settingsElem, context );
+    QgsPalLayerSettings settings;
+    settings.readXml( settingsElem, context );
+    return new QgsVectorLayerSimpleLabeling( settings );
   }
 
-  return new QgsVectorLayerSimpleLabeling( *settings );
+  return new QgsVectorLayerSimpleLabeling( QgsPalLayerSettings() );
 }