Crazy fix to avoid shared data getting corrupted in sip bindings

Without this (should be unnecessary) virtual destructor the shared data member for QgsProperty gets filled with garbage if a QgsProperty is created from python code. I can't explain it...!
qgis · Jan 23, 2017 · fa26b45 · fa26b45
1 parent c3617de
commit fa26b45
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/python/core/qgsproperty.sip b/python/core/qgsproperty.sip
@@ -76,6 +76,8 @@ class QgsProperty
     };
 
     QgsProperty();
+    virtual ~QgsProperty();
+
     static QgsProperty fromExpression( const QString& expression, bool isActive = true );
     static QgsProperty fromField( const QString& fieldName, bool isActive = true );
     static QgsProperty fromValue( const QVariant& value, bool isActive = true );

diff --git a/src/core/qgsproperty.h b/src/core/qgsproperty.h
@@ -191,6 +191,8 @@ class CORE_EXPORT QgsProperty
      */
     QgsProperty();
 
+    virtual ~QgsProperty() = default;
+
     /**
      * Returns a new ExpressionBasedProperty created from the specified expression.
      */