[server][bugfix] Prevent potential crash

elpaso · elpaso · commit f986d74cb83d · 2016-02-23T10:07:09.000+01:00
diff --git a/src/server/qgshttprequesthandler.cpp b/src/server/qgshttprequesthandler.cpp
@@ -43,6 +43,7 @@ QgsHttpRequestHandler::QgsHttpRequestHandler( const bool captureOutput )
 
 QgsHttpRequestHandler::~QgsHttpRequestHandler()
 {
+  delete mException;
 }
 
 void QgsHttpRequestHandler::setHttpResponse( QByteArray *ba, const QString &format )
@@ -455,7 +456,7 @@ void QgsHttpRequestHandler::setGetFeatureInfoResponse( const QDomDocument& infoD
 
 void QgsHttpRequestHandler::setServiceException( QgsMapServiceException ex )
 {
-  mException = &ex;
+  mException = new QgsMapServiceException( ex );
   //create Exception DOM document
   QDomDocument exceptionDoc;
   QDomElement serviceExceptionReportElem = exceptionDoc.createElement( "ServiceExceptionReport" );

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ QgsHttpRequestHandler::QgsHttpRequestHandler( const bool captureOutput )`
`43`	`43`
`44`	`44`	`QgsHttpRequestHandler::~QgsHttpRequestHandler()`
`45`	`45`	`{`
	`46`	`+ delete mException;`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`void QgsHttpRequestHandler::setHttpResponse( QByteArray *ba, const QString &format )`
`@@ -455,7 +456,7 @@ void QgsHttpRequestHandler::setGetFeatureInfoResponse( const QDomDocument& infoD`
`455`	`456`
`456`	`457`	`void QgsHttpRequestHandler::setServiceException( QgsMapServiceException ex )`
`457`	`458`	`{`
`458`		`- mException = &ex;`
	`459`	`+ mException = new QgsMapServiceException( ex );`
`459`	`460`	`//create Exception DOM document`
`460`	`461`	`QDomDocument exceptionDoc;`
`461`	`462`	`QDomElement serviceExceptionReportElem = exceptionDoc.createElement( "ServiceExceptionReport" );`