Fix some processing algorithm exception handling

nyalldawson · nyalldawson · commit f8e37aa7cb24 · 2017-07-08T20:49:17.000+10:00
diff --git a/src/core/processing/qgsnativealgorithms.cpp b/src/core/processing/qgsnativealgorithms.cpp
@@ -1035,8 +1035,7 @@ QVariantMap QgsExtractByAttributeAlgorithm::processAlgorithm( const QVariantMap
   QgsExpression expression( expr );
   if ( expression.hasParserError() )
   {
-    // raise GeoAlgorithmExecutionException(expression.parserErrorString())
-    return QVariantMap();
+    throw QgsProcessingException( expression.parserErrorString() );
   }
 
   QgsExpressionContext expressionContext = createExpressionContext( parameters, context );

Original file line number	Diff line number	Diff line change
`@@ -1035,8 +1035,7 @@ QVariantMap QgsExtractByAttributeAlgorithm::processAlgorithm( const QVariantMap`
`1035`	`1035`	`QgsExpression expression( expr );`
`1036`	`1036`	`if ( expression.hasParserError() )`
`1037`	`1037`	`{`
`1038`		`- // raise GeoAlgorithmExecutionException(expression.parserErrorString())`
`1039`		`- return QVariantMap();`
	`1038`	`+ throw QgsProcessingException( expression.parserErrorString() );`
`1040`	`1039`	`}`
`1041`	`1040`
`1042`	`1041`	`QgsExpressionContext expressionContext = createExpressionContext( parameters, context );`