[processing] Fix Refactor Fields rejects valid field configuration input

nyalldawson · nyalldawson · commit f8cf2f4dbe2c · 2017-09-26T13:58:01.000+10:00
diff --git a/python/plugins/processing/algs/qgis/FieldsMapper.py b/python/plugins/processing/algs/qgis/FieldsMapper.py
@@ -68,7 +68,7 @@ def checkValueIsAcceptable(self, value, context=None):
                         return False
                     if not field_def.get('name', False):
                         return False
-                    if not field_def.get('type', False):
+                    if field_def.get('type', None) is None:
                         return False
                     if not field_def.get('expression', False):
                         return False

-Original file line number
+Diff line change
                         return False
                     if not field_def.get('name', False):
                         return False
 -                    if not field_def.get('type', False):Collapse commentComment on line R71
m-kuhn commented on Sep 26, 2017 
m-kuhn
on Sep 26, 2017
Member
Is field_def not something like a QList where you could call field_def.contains('type')?

Just a random thought while reading this.
nyalldawson replied on Sep 26, 2017 
nyalldawson
on Sep 26, 2017
CollaboratorAuthor
It's a python dict. I agree this could be cleaner.
m-kuhn replied on Sep 26, 2017 
m-kuhn
on Sep 26, 2017
Member
#5257
Code has comments. Press enter to view.
 +                    if field_def.get('type', None) is None:
                         return False
                     if not field_def.get('expression', False):
                         return False