Skip to content

Commit

Permalink
Rename QgsPolymorphicRelations getGeneratedRelations -> generateRelat…
Browse files Browse the repository at this point in the history
…ions
  • Loading branch information
suricactus committed Jan 12, 2021
1 parent 41e1e61 commit f8b468a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion python/core/auto_generated/qgspolymorphicrelation.sip.in
Expand Up @@ -219,7 +219,7 @@ Sets a list of layer ids to be used as potential referenced layers
Returns a list of layer ids to be used as potential referenced layers
%End

QList<QgsRelation> getGeneratedRelations() const;
QList<QgsRelation> generateRelations() const;
%Docstring
Returns a list of generated relations, based on the currently set :py:func:`~QgsPolymorphicRelation.referencedLayerIds`
%End
Expand Down
2 changes: 1 addition & 1 deletion src/core/qgspolymorphicrelation.cpp
Expand Up @@ -357,7 +357,7 @@ QStringList QgsPolymorphicRelation::referencedLayerIds() const
return d->mReferencedLayerIds;
}

QList<QgsRelation> QgsPolymorphicRelation::getGeneratedRelations() const
QList<QgsRelation> QgsPolymorphicRelation::generateRelations() const
{
QList<QgsRelation> relations;

Expand Down
2 changes: 1 addition & 1 deletion src/core/qgspolymorphicrelation.h
Expand Up @@ -267,7 +267,7 @@ class CORE_EXPORT QgsPolymorphicRelation
/**
* Returns a list of generated relations, based on the currently set referencedLayerIds()
*/
QList<QgsRelation> getGeneratedRelations() const;
QList<QgsRelation> generateRelations() const;

/**
* Returns layer representation as evaluated string
Expand Down
4 changes: 2 additions & 2 deletions src/core/qgsrelationmanager.cpp
Expand Up @@ -328,7 +328,7 @@ void QgsRelationManager::addPolymorphicRelation( const QgsPolymorphicRelation &p

mPolymorphicRelations.insert( polymorphicRelation.id(), polymorphicRelation );

const QList<QgsRelation> generatedRelations = polymorphicRelation.getGeneratedRelations();
const QList<QgsRelation> generatedRelations = polymorphicRelation.generateRelations();
for ( const QgsRelation &generatedRelation : generatedRelations )
addRelation( generatedRelation );
}
Expand All @@ -337,7 +337,7 @@ void QgsRelationManager::removePolymorphicRelation( const QString &polymorphicRe
{
QgsPolymorphicRelation relation = mPolymorphicRelations.take( polymorphicRelationId );

const QList<QgsRelation> generatedRelations = relation.getGeneratedRelations();
const QList<QgsRelation> generatedRelations = relation.generateRelations();
for ( const QgsRelation &generatedRelation : generatedRelations )
removeRelation( generatedRelation.id() );
}
Expand Down
4 changes: 2 additions & 2 deletions tests/src/python/test_qgspolymorphicrelation.py
Expand Up @@ -164,7 +164,7 @@ def test_layerRepresentation(self):

self.assertEqual(poly_rel.layerRepresentation(self.referencedLayer1), 'referencedlayer1')

def test_getGeneratedRelations(self):
def test_generateRelations(self):
poly_rel = QgsPolymorphicRelation()
poly_rel.setId('poly_rel1')
poly_rel.setName('Polymorphic Relation Number One')
Expand All @@ -178,7 +178,7 @@ def test_getGeneratedRelations(self):

self.assertTrue(poly_rel.isValid())

rels = poly_rel.getGeneratedRelations()
rels = poly_rel.generateRelations()

self.assertEqual(len(rels), 2)

Expand Down

0 comments on commit f8b468a

Please sign in to comment.