QgsFields: make icon for type static

qgis · Jul 6, 2020 · f89fb2a · f89fb2a
1 parent a0c3f6f
commit f89fb2a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/python/core/auto_generated/qgsfields.sip.in b/python/core/auto_generated/qgsfields.sip.in
@@ -309,6 +309,14 @@ Returns an icon corresponding to a field index, based on the field's type and so
     }
 %End
 
+
+    static QIcon iconForFieldType( const QVariant::Type &type ) /Factory/;
+%Docstring
+Returns an icon corresponding to a field ``type``
+
+.. versionadded:: 3.16
+%End
+
     operator QVariant() const;
 
 

diff --git a/src/core/qgsfields.cpp b/src/core/qgsfields.cpp
@@ -274,7 +274,12 @@ QgsFields::iterator QgsFields::end()
 
 QIcon QgsFields::iconForField( int fieldIdx ) const
 {
-  switch ( d->fields.at( fieldIdx ).field.type() )
+  return QgsFields::iconForFieldType( d->fields.at( fieldIdx ).field.type() );
+}
+
+QIcon QgsFields::iconForFieldType( const QVariant::Type &type )
+{
+  switch ( type )
   {
     case QVariant::Bool:
       return QgsApplication::getThemeIcon( "/mIconFieldBool.svg" );

diff --git a/src/core/qgsfields.h b/src/core/qgsfields.h
@@ -338,6 +338,13 @@ class CORE_EXPORT  QgsFields
     % End
 #endif
 
+
+    /**
+     * Returns an icon corresponding to a field \a type
+     * \since QGIS 3.16
+     */
+    static QIcon iconForFieldType( const QVariant::Type &type ) SIP_FACTORY;
+
     //! Allows direct construction of QVariants from fields.
     operator QVariant() const
     {