Disable OGR expression compilation for certain OGR drivers

In some cases OGR forwards filters on to the underlying data source, and the syntax may differ from OGR SQL. In these cases disable expression compilation.
qgis · Nov 17, 2015 · f7ed42b · f7ed42b
1 parent 3d947e8
commit f7ed42b
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/src/providers/ogr/qgsogrexpressioncompiler.cpp b/src/providers/ogr/qgsogrexpressioncompiler.cpp
@@ -29,6 +29,24 @@ QgsOgrExpressionCompiler::~QgsOgrExpressionCompiler()
 
 QgsOgrExpressionCompiler::Result QgsOgrExpressionCompiler::compile( const QgsExpression* exp )
 {
+  //for certain driver types, OGR forwards SQL through to the underlying provider. In these cases
+  //the syntax may differ from OGR SQL, so we don't support compilation for these drivers
+  //see http://www.gdal.org/ogr_sql.html
+  if ( mSource->mDriverName == "MySQL" )
+    return Fail;
+  else if ( mSource->mDriverName == "PostgreSQL" )
+    return Fail;
+  else if ( mSource->mDriverName == "OCI" )
+    return Fail;
+  else if ( mSource->mDriverName == "SQLite" )
+    return Fail;
+  else if ( mSource->mDriverName == "ODBC" )
+    return Fail;
+  else if ( mSource->mDriverName == "PGeo" )
+    return Fail;
+  else if ( mSource->mDriverName == "MSSQLSpatial" )
+    return Fail;
+
   if ( exp->rootNode() )
     return compile( exp->rootNode(), mResult );
   else