address reviews 2

qgis · Jan 14, 2022 · f7c043d · f7c043d
1 parent e789f79
commit f7c043d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/app/3d/qgs3dmapcanvaswidget.cpp b/src/app/3d/qgs3dmapcanvaswidget.cpp
@@ -140,7 +140,7 @@ Qgs3DMapCanvasWidget::Qgs3DMapCanvasWidget( QWidget *parent )
   mDockUnDockBtn->setCheckable( true );
   mDockUnDockBtn->setChecked( true );
   mDockUnDockBtn->setEnabled( true );
-  connect( mDockUnDockBtn, &QToolButton::toggled, this, &Qgs3DMapCanvasWidget::toggleDockMode );
+  connect( mDockUnDockBtn, &QToolButton::toggled, this, &Qgs3DMapCanvasWidget::toggleDockModeRequested );
 
   toolBar->addWidget( mDockUnDockBtn );
 

diff --git a/src/app/3d/qgs3dmapcanvaswidget.h b/src/app/3d/qgs3dmapcanvaswidget.h
@@ -52,7 +52,7 @@ class APP_EXPORT Qgs3DMapCanvasWidget : public QWidget
     void setDocked( bool docked );
 
   signals:
-    void toggleDockMode( bool docked );
+    void toggleDockModeRequested( bool docked );
 
   private slots:
     void resetView();

diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -13986,7 +13986,7 @@ QgsDockableWidget *QgisApp::createNew3DMapCanvasDock( const QString &name )
   QgsDockableWidget *map3DWidget = new QgsDockableWidget( this );
   Qgs3DMapCanvasWidget *widget = new Qgs3DMapCanvasWidget( map3DWidget );
   map3DWidget->setWidget( widget );
-  connect( widget, &Qgs3DMapCanvasWidget::toggleDockMode, map3DWidget, &QgsDockableWidget::toggleDockMode );
+  connect( widget, &Qgs3DMapCanvasWidget::toggleDockModeRequested, map3DWidget, &QgsDockableWidget::toggleDockMode );
 
   mOpen3DDocks.insert( map3DWidget );
   map3DWidget->setWindowTitle( name );