Skip to content

Commit f638b3c

Browse files
committedFeb 24, 2018
[processing] fix wrong variable name in GDAL alggorithms base class
1 parent 725f360 commit f638b3c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎python/plugins/processing/algs/gdal/GdalAlgorithm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def helpUrl(self):
133133

134134
def commandName(self):
135135
parameters = {}
136-
for output in self.outputs:
136+
for output in self.outputDefinitions():
137137
output.setValue("dummy")
138138
for param in self.parameterDefinitions():
139139
parameters[param.name()] = "1"

4 commit comments

Comments
 (4)

ghtmtt commented on Feb 24, 2018

@ghtmtt
Contributor

Hi @alexbruy I think you are taking care of https://issues.qgis.org/issues/18198. I re-build QGIS and I still have a stack trace:

Traceback (most recent call last):
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 132, in helpUrl
    return helpPath + '{}.html'.format(self.commandName())
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 137, in commandName
    output.setValue("dummy")
AttributeError: 'QgsProcessingOutputRasterLayer' object has no attribute 'setValue'

I don't know if other commits are coming and/or comments like this help you. In case just ignore them ;)

Thanks for all this work!

alexbruy commented on Feb 24, 2018

@alexbruy
ContributorAuthor

@ghtmtt thanks for the information. I can't reproduce it (as well as #18198). Looking now.

alexbruy commented on Feb 24, 2018

@alexbruy
ContributorAuthor

@ghtmtt can you try with f3af22e?

ghtmtt commented on Feb 24, 2018

@ghtmtt
Contributor

I get this stack trace:

Traceback (most recent call last):
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 132, in helpUrl
    return helpPath + '{}.html'.format(self.commandName())
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 137, in commandName
    results[output.name()] = "dummy"
NameError: name 'results' is not defined
Please sign in to comment.