Skip to content

Commit

Permalink
[processing] fix wrong variable name in GDAL alggorithms base class
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexbruy
alexbruy committed Feb 24, 2018
1 parent 725f360 commit f638b3c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/plugins/processing/algs/gdal/GdalAlgorithm.py
View file
Expand Up @@ -133,7 +133,7 @@ def helpUrl(self):

def commandName(self):
parameters = {}
for output in self.outputs:
for output in self.outputDefinitions():
output.setValue("dummy")
for param in self.parameterDefinitions():
parameters[param.name()] = "1"
Expand Down

4 comments on commit f638b3c

@ghtmtt
Copy link
Contributor

@ghtmtt ghtmtt commented on f638b3c Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexbruy I think you are taking care of https://issues.qgis.org/issues/18198. I re-build QGIS and I still have a stack trace:

Traceback (most recent call last):
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 132, in helpUrl
    return helpPath + '{}.html'.format(self.commandName())
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 137, in commandName
    output.setValue("dummy")
AttributeError: 'QgsProcessingOutputRasterLayer' object has no attribute 'setValue'

I don't know if other commits are coming and/or comments like this help you. In case just ignore them ;)

Thanks for all this work!

@alexbruy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghtmtt thanks for the information. I can't reproduce it (as well as #18198). Looking now.

@alexbruy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghtmtt can you try with f3af22e?

@ghtmtt
Copy link
Contributor

@ghtmtt ghtmtt commented on f638b3c Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this stack trace:

Traceback (most recent call last):
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 132, in helpUrl
    return helpPath + '{}.html'.format(self.commandName())
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 137, in commandName
    results[output.name()] = "dummy"
NameError: name 'results' is not defined

Please sign in to comment.