QgsXmlUtils::readFlagAttribute(): fix use-after-free

Found with Valgrind ```const char* c_str = qstr.toUtf8().data()``` is invalid since the QByteArray returned by toUtf8() is destroyed at the end of the expression, letting c_str point to freed memory On the contrary ```foo(qstr.toUtf8().data())``` is valid since the temporary object is destroyed only after foo invokation.
qgis · Oct 6, 2018 · f5d2d85 · f5d2d85
1 parent 81db005
commit f5d2d85
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/core/qgsxmlutils.h b/src/core/qgsxmlutils.h
@@ -97,8 +97,7 @@ class CORE_EXPORT QgsXmlUtils
       if ( metaEnum.isValid() )
       {
         bool ok = false;
-        const char *vs = sourceCategoriesStr.toUtf8().data();
-        int newValue = metaEnum.keysToValue( vs, &ok );
+        int newValue = metaEnum.keysToValue( sourceCategoriesStr.toUtf8().data(), &ok );
         if ( ok )
           value = static_cast<T>( newValue );
       }