Project dirtying improvements

- Mark as dirty when renaming a layer/group - Better approach to mark as dirty when changing CRS - Better approach to mark as dirty when changing subset string
qgis · May 29, 2018 · f5c0a2c · f5c0a2c
1 parent b202d60
commit f5c0a2c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -9632,7 +9632,6 @@ void QgisApp::setLayerCrs()
     }
   }
 
-  markDirty();
   refreshMapCanvas();
 }
 

diff --git a/src/core/qgsmaplayer.cpp b/src/core/qgsmaplayer.cpp
@@ -93,6 +93,9 @@ QgsMapLayer::QgsMapLayer( QgsMapLayer::LayerType type,
   // there for the compiler, so the pattern is actually \W
   mID.replace( QRegExp( "[\\W]" ), QStringLiteral( "_" ) );
 
+  connect( this, &QgsMapLayer::crsChanged, this, &QgsMapLayer::configChanged );
+  connect( this, &QgsMapLayer::nameChanged, this, &QgsMapLayer::configChanged );
+
   connect( mStyleManager, &QgsMapLayerStyleManager::currentStyleChanged, this, &QgsMapLayer::styleChanged );
   connect( mRefreshTimer, &QTimer::timeout, this, [ = ] { triggerRepaint( true ); } );
 }

diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -896,7 +896,10 @@ bool QgsVectorLayer::setSubsetString( const QString &subset )
   updateFields();
 
   if ( res )
+  {
+    emit configChanged();
     emit repaintRequested();
+  }
 
   return res;
 }

diff --git a/src/gui/qgsquerybuilder.cpp b/src/gui/qgsquerybuilder.cpp
@@ -264,7 +264,6 @@ void QgsQueryBuilder::accept()
 
       return;
     }
-    QgsProject::instance()->setDirty( true );
   }
 
   QDialog::accept();