[processing] Fix capitalization, ellipsis in extent parameter widget

nyalldawson · nyalldawson · commit f44be44ca9cd · 2018-09-21T13:16:13.000+10:00
diff --git a/python/plugins/processing/gui/ExtentSelectionPanel.py b/python/plugins/processing/gui/ExtentSelectionPanel.py
@@ -97,9 +97,9 @@ def __init__(self, dialog, param):
     def selectExtent(self):
         popupmenu = QMenu()
         useLayerExtentAction = QAction(
-            self.tr('Use layer/canvas extent'), self.btnSelect)
+            self.tr('Use Layer/Canvas Extent…'), self.btnSelect)
         selectOnCanvasAction = QAction(
-            self.tr('Select extent on canvas'), self.btnSelect)
+            self.tr('Select Extent on Canvas'), self.btnSelect)
 
         popupmenu.addAction(useLayerExtentAction)
         popupmenu.addAction(selectOnCanvasAction)
@@ -109,7 +109,7 @@ def selectExtent(self):
 
         if self.param.flags() & QgsProcessingParameterDefinition.FlagOptional:
             useMincoveringExtentAction = QAction(
-                self.tr('Use min covering extent from input layers'),
+                self.tr('Use Min Covering Extent from Input Layers'),
                 self.btnSelect)
             useMincoveringExtentAction.triggered.connect(
                 self.useMinCoveringExtent)
@@ -121,7 +121,7 @@ def useMinCoveringExtent(self):
         self.leText.setText('')
 
     def useLayerExtent(self):
-        CANVAS_KEY = 'Use canvas extent'
+        CANVAS_KEY = 'Canvas Extent'
         extentsDict = {}
         extentsDict[CANVAS_KEY] = {"extent": iface.mapCanvas().extent(),
                                    "authid": iface.mapCanvas().mapSettings().destinationCrs().authid()}

-Original file line number
+Diff line change
     def selectExtent(self):
         popupmenu = QMenu()
         useLayerExtentAction = QAction(
 -            self.tr('Use layer/canvas extent'), self.btnSelect)
 +            self.tr('Use Layer/Canvas Extent…'), self.btnSelect)
         selectOnCanvasAction = QAction(
 -            self.tr('Select extent on canvas'), self.btnSelect)
 +            self.tr('Select Extent on Canvas'), self.btnSelect)
         popupmenu.addAction(useLayerExtentAction)
         popupmenu.addAction(selectOnCanvasAction)
         if self.param.flags() & QgsProcessingParameterDefinition.FlagOptional:
             useMincoveringExtentAction = QAction(
 -                self.tr('Use min covering extent from input layers'),
 +                self.tr('Use Min Covering Extent from Input Layers'),Collapse commentComment on line R112
nirvn commented on Sep 21, 2018 
nirvn
on Sep 21, 2018
Contributor
@nyalldawson , any reason why we use "Min" instead of "Minimum" here? I don' think we're constrained in space here, we might as well use the full word.
nyalldawson replied on Sep 21, 2018 
nyalldawson
on Sep 21, 2018
CollaboratorAuthor
It could be reworded even better I think: "Extent of all Input Layers"?
nirvn replied on Sep 21, 2018 
nirvn
on Sep 21, 2018
Contributor
Combined Extent of all Input Layers? As long as Min goes away, I'm happy 😉
nyalldawson replied on Sep 21, 2018 
nyalldawson
on Sep 21, 2018
CollaboratorAuthor
go for it :D
Code has comments. Press enter to view.
                 self.btnSelect)
             useMincoveringExtentAction.triggered.connect(
                 self.useMinCoveringExtent)
         self.leText.setText('')
     def useLayerExtent(self):
 -        CANVAS_KEY = 'Use canvas extent'
 +        CANVAS_KEY = 'Canvas Extent'
         extentsDict = {}
         extentsDict[CANVAS_KEY] = {"extent": iface.mapCanvas().extent(),
                                    "authid": iface.mapCanvas().mapSettings().destinationCrs().authid()}