Merge pull request #6236 from elpaso/double-linedit-default-widget

[bugfix] Lower priority of range widget for doubles
qgis · Feb 1, 2018 · f3f0eb0 · f3f0eb0
2 parents cc92107 + 2263237
commit f3f0eb0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/gui/editorwidgets/qgsrangewidgetfactory.cpp b/src/gui/editorwidgets/qgsrangewidgetfactory.cpp
@@ -37,7 +37,8 @@ QgsEditorConfigWidget *QgsRangeWidgetFactory::configWidget( QgsVectorLayer *vl,
 unsigned int QgsRangeWidgetFactory::fieldScore( const QgsVectorLayer *vl, int fieldIdx ) const
 {
   const QgsField field = vl->fields().at( fieldIdx );
-  if ( field.type() == QVariant::Int || field.type() == QVariant::Double ) return 20;
+  if ( field.type() == QVariant::Int ) return 20;
+  if ( field.type() == QVariant::Double ) return 5; // low priority because the fixed number of decimal places may alter the original data
   if ( field.isNumeric() ) return 5; // widgets used support only signed 32bits (int) and double
   return 0;
 }

diff --git a/tests/src/gui/testqgseditorwidgetregistry.cpp b/tests/src/gui/testqgseditorwidgetregistry.cpp
@@ -77,7 +77,7 @@ class TestQgsEditorWidgetRegistry: public QObject
 
     void doubleType()
     {
-      checkSimple( QStringLiteral( "double" ), QStringLiteral( "Range" ) );
+      checkSimple( QStringLiteral( "double" ), QStringLiteral( "TextEdit" ) );
     }
 
     void arrayType()