FieldExpressionWidget: add tooltip if expression is larger than widget

qgis · Jun 6, 2014 · f380df1 · f380df1
1 parent 63af881
commit f380df1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/python/gui/qgsfieldexpressionwidget.sip b/python/gui/qgsfieldexpressionwidget.sip
@@ -63,7 +63,7 @@ class QgsFieldExpressionWidget : QWidget
     //! when expression has been edited (finished) it will be added to the model
     void expressionEditingFinished();
 
-    void currentFieldChanged( int i = 0 );
+    void currentFieldChanged();
 
     /**
      * @brief updateLineEditStyle will re-style (color/font) the line edit depending on content and status

diff --git a/src/gui/qgsfieldexpressionwidget.cpp b/src/gui/qgsfieldexpressionwidget.cpp
@@ -195,6 +195,18 @@ void QgsFieldExpressionWidget::currentFieldChanged( int i /* =0 */ )
 
   bool isExpression, isValid;
   QString fieldName = currentField( &isExpression, &isValid );
+
+  // display tooltip if widget is shorter than expression
+  QFontMetrics metrics( mCombo->lineEdit()->font() );
+  if ( metrics.width( fieldName ) > mCombo->lineEdit()->width() )
+  {
+    mCombo->setToolTip( fieldName );
+  }
+  else
+  {
+    mCombo->setToolTip( "" );
+  }
+
   emit fieldChanged( fieldName );
   emit fieldChanged( fieldName, isValid );
 }