Use forward only cursor in all queries

szekerest · NathanW2 · commit f375e351f34d · 2012-03-28T21:56:30.000+10:00
diff --git a/src/providers/mssql/qgsmssqlprovider.cpp b/src/providers/mssql/qgsmssqlprovider.cpp
@@ -354,6 +354,7 @@ void QgsMssqlProvider::loadFields()
     if ( mFidColName.isEmpty() )
     {
       mQuery.clear();
+      mQuery.setForwardOnly( true );
       if (!mQuery.exec( QString( "exec sp_pkeys N'%1', NULL, NULL" ).arg( mTableName ) ))
       {
         QString msg = mQuery.lastError().text();
@@ -370,6 +371,7 @@ void QgsMssqlProvider::loadFields()
       foreach( QString pk, pkCandidates )
       {
         mQuery.clear();
+        mQuery.setForwardOnly( true );
         if (!mQuery.exec( QString( "select count(distinct [%1]), count([%1]) from [%2].[%3]" )
             .arg( pk )
             .arg( mSchemaName )

Original file line number	Diff line number	Diff line change
`@@ -354,6 +354,7 @@ void QgsMssqlProvider::loadFields()`
`354`	`354`	`if ( mFidColName.isEmpty() )`
`355`	`355`	`{`
`356`	`356`	`mQuery.clear();`
	`357`	`+ mQuery.setForwardOnly( true );`
`357`	`358`	`if (!mQuery.exec( QString( "exec sp_pkeys N'%1', NULL, NULL" ).arg( mTableName ) ))`
`358`	`359`	`{`
`359`	`360`	`QString msg = mQuery.lastError().text();`
`@@ -370,6 +371,7 @@ void QgsMssqlProvider::loadFields()`
`370`	`371`	`foreach( QString pk, pkCandidates )`
`371`	`372`	`{`
`372`	`373`	`mQuery.clear();`
	`374`	`+ mQuery.setForwardOnly( true );`
`373`	`375`	`if (!mQuery.exec( QString( "select count(distinct [%1]), count([%1]) from [%2].[%3]" )`
`374`	`376`	`.arg( pk )`
`375`	`377`	`.arg( mSchemaName )`