Merge pull request #40682 from tomtor/FixRecentProjectsGui

Remove updateRecentProjectsVisibility()
qgis · Jan 27, 2021 · f3632e8 · f3632e8
2 parents 84e2aeb + 9e05efa
commit f3632e8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/src/app/qgswelcomepage.cpp b/src/app/qgswelcomepage.cpp
@@ -75,11 +75,6 @@ QgsWelcomePage::QgsWelcomePage( bool skipVersionCheck, QWidget *parent )
   mRecentProjectsListView->setModel( mRecentProjectsModel );
   QgsProjectListItemDelegate *recentProjectsDelegate = new QgsProjectListItemDelegate( mRecentProjectsListView );
   mRecentProjectsListView->setItemDelegate( recentProjectsDelegate );
-  connect( mRecentProjectsModel, &QAbstractItemModel::rowsRemoved, this, [this]
-  {
-    updateRecentProjectsVisibility();
-  }
-         );
 
   leftLayout->addWidget( mRecentProjectsListView, 1 );
   leftContainer->setLayout( leftLayout );
@@ -150,6 +145,8 @@ QgsWelcomePage::QgsWelcomePage( bool skipVersionCheck, QWidget *parent )
 
   rightContainer->setLayout( rightLayout );
   mSplitter->addWidget( rightContainer );
+  mSplitter->setStretchFactor( 0, 4 );
+  mSplitter->setStretchFactor( 1, 6 );
 
   mVersionInformation = new QTextBrowser;
   mVersionInformation->setSizePolicy( QSizePolicy::Expanding, QSizePolicy::Maximum );
@@ -194,7 +191,6 @@ QgsWelcomePage::~QgsWelcomePage()
 void QgsWelcomePage::setRecentProjects( const QList<QgsRecentProjectItemsModel::RecentProjectData> &recentProjects )
 {
   mRecentProjectsModel->setRecentProjects( recentProjects );
-  updateRecentProjectsVisibility();
 }
 
 QString QgsWelcomePage::newsFeedUrl()
@@ -411,13 +407,6 @@ void QgsWelcomePage::showContextMenuForNews( QPoint point )
   menu->popup( mNewsFeedListView->mapToGlobal( point ) );
 }
 
-void QgsWelcomePage::updateRecentProjectsVisibility()
-{
-  const bool visible = mRecentProjectsModel->rowCount() > 0;
-  mRecentProjectsListView->setVisible( visible );
-  mRecentProjectsTitle->setVisible( visible );
-}
-
 void QgsWelcomePage::updateNewsFeedVisibility()
 {
   if ( !mNewsFeedModel || !mNewsFeedListView || !mSplitter2 )

diff --git a/src/app/qgswelcomepage.h b/src/app/qgswelcomepage.h
@@ -68,8 +68,6 @@ class QgsWelcomePage : public QWidget
     void updateNewsFeedVisibility();
 
   private:
-    void updateRecentProjectsVisibility();
-
     QgsRecentProjectItemsModel *mRecentProjectsModel = nullptr;
     QTextBrowser *mVersionInformation = nullptr;
     QgsVersionInfo *mVersionInfo = nullptr;