Apply suggestions from code review

Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
qgis · Sep 5, 2020 · f1ce637 · f1ce637
1 parent 3c79dc9
commit f1ce637
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/core/qgstemporalnavigationobject.h b/src/core/qgstemporalnavigationobject.h
@@ -220,7 +220,7 @@ class CORE_EXPORT QgsTemporalNavigationObject : public QgsTemporalController, pu
     /**
      * Emitted whenever the temporalExtent \a extent changes.
      */
-    void temporalExtentsChanged( QgsDateTimeRange extent );
+    void temporalExtentsChanged( const QgsDateTimeRange &extent );
 
   public slots:
 

diff --git a/src/gui/qgstemporalcontrollerwidget.cpp b/src/gui/qgstemporalcontrollerwidget.cpp
@@ -577,7 +577,7 @@ void QgsTemporalControllerWidget::setDates( const QgsDateTimeRange &range )
     whileBlocking( mFixedRangeEndDateTime )->setDateTime( range.end() );
     // only if range is different from mNavigationObject->temporalExtents update
     // else recursion as updateTemporalExtent itself calls mNavigationObject->setTemporalExtents
-    if ( !( range == mNavigationObject->temporalExtents() ) )
+    if ( range != mNavigationObject->temporalExtents() )
     {
       updateTemporalExtent();
     }