Skip to content

Commit

Permalink
[composer] Fix failing rotation tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Dec 30, 2013
1 parent 0437dbb commit f1aead4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/core/composer/qgscomposeritem.cpp
Expand Up @@ -707,7 +707,7 @@ void QgsComposerItem::setRotation( double r )
{
//kept for api compatibility with QGIS 2.0
//remove after 2.0 series
setItemRotation( r );
setItemRotation( r, true );
}

void QgsComposerItem::setItemRotation( double r, bool adjustPosition )
Expand Down
14 changes: 8 additions & 6 deletions tests/src/core/testqgscomposerrotation.cpp
Expand Up @@ -130,12 +130,13 @@ void TestQgsComposerRotation::shapeRotation()
{
mComposition->addComposerShape( mComposerRect );

mComposerRect->setItemRotation( 45 );
mComposerRect->setItemRotation( 45, true );

QgsCompositionChecker checker( "composerrotation_shape", mComposition );
QVERIFY( checker.testComposition( mReport ) );

mComposition->removeItem( mComposerRect );
mComposerRect->setItemRotation( 0, true );
}

void TestQgsComposerRotation::oldShapeRotationApi()
Expand All @@ -155,12 +156,13 @@ void TestQgsComposerRotation::labelRotation()
{
mComposition->addComposerLabel( mComposerLabel );

mComposerLabel->setItemRotation( 135 );
mComposerLabel->setItemRotation( 135, true );

QgsCompositionChecker checker( "composerrotation_label", mComposition );
QVERIFY( checker.testComposition( mReport ) );

mComposition->removeItem( mComposerLabel );
mComposerLabel->setItemRotation( 0, true );
}

void TestQgsComposerRotation::oldLabelRotationApi()
Expand Down Expand Up @@ -195,13 +197,13 @@ void TestQgsComposerRotation::mapItemRotation()
//test map item rotation
mComposition->addComposerMap( mComposerMap );
mComposerMap->setNewExtent( QgsRectangle( 781662.375, 3339523.125, 793062.375, 3345223.125 ) );
mComposerMap->setItemRotation( 90 );
mComposerMap->setItemRotation( 90, true );

QgsCompositionChecker checker( "composerrotation_mapitemrotation", mComposition );
QVERIFY( checker.testComposition( mReport ) );

mComposition->removeItem( mComposerMap );
mComposerMap->setItemRotation( 0 );
mComposerMap->setItemRotation( 0, true );
}

void TestQgsComposerRotation::oldMapRotationApi()
Expand Down Expand Up @@ -235,13 +237,13 @@ void TestQgsComposerRotation::pictureItemRotation()
{
//test picture item rotation
mComposition->addComposerPicture( mComposerPicture );
mComposerPicture->setItemRotation( 45 );
mComposerPicture->setItemRotation( 45, true );

QgsCompositionChecker checker( "composerrotation_pictureitemrotation", mComposition );
QVERIFY( checker.testComposition( mReport ) );

mComposition->removeItem( mComposerPicture );
mComposerPicture->setItemRotation( 0 );
mComposerPicture->setItemRotation( 0, true );
}

void TestQgsComposerRotation::oldPictureRotationApi()
Expand Down

0 comments on commit f1aead4

Please sign in to comment.