Skip to content

Commit

Permalink
Disable geometry simplify check
Browse files Browse the repository at this point in the history
This test mixes different effects and is very unprecise in what it tests and
what it expects as result.
  • Loading branch information
m-kuhn committed Nov 14, 2014
1 parent 4b843e4 commit f0efa6d
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions tests/src/core/testqgsgeometry.cpp
Expand Up @@ -53,7 +53,11 @@ class TestQgsGeometry: public QObject
void asQPointF();
void asQPolygonF();

// MK, Disabled 14.11.2014
// Too unclear what exactly should be tested and which variations are allowed for the line
#if 0
void simplifyCheck1();
#endif
void intersectionCheck1();
void intersectionCheck2();
void unionCheck1();
Expand All @@ -64,7 +68,7 @@ class TestQgsGeometry: public QObject

private:
/** A helper method to do a render check to see if the geometry op is as expected */
bool renderCheck( QString theTestName, QString theComment = "" );
bool renderCheck( QString theTestName, QString theComment = "", int mismatchCount = 0 );
/** A helper method to dump to qdebug the geometry of a multipolygon */
void dumpMultiPolygon( QgsMultiPolygon &theMultiPolygon );
/** A helper method to dump to qdebug the geometry of a polygon */
Expand Down Expand Up @@ -318,6 +322,9 @@ void TestQgsGeometry::cleanupTestCase()

}

// MK, Disabled 14.11.2014
// Too unclear what exactly should be tested and which variations are allowed for the line
#if 0
void TestQgsGeometry::simplifyCheck1()
{
QVERIFY( mpPolylineGeometryD->simplify( 0.5 ) );
Expand All @@ -331,6 +338,8 @@ void TestQgsGeometry::simplifyCheck1()
delete mypSimplifyGeometry;
QVERIFY( renderCheck( "geometry_simplifyCheck1", "Checking simplify of line" ) );
}
#endif

void TestQgsGeometry::intersectionCheck1()
{
QVERIFY( mpPolygonGeometryA->intersects( mpPolygonGeometryB ) );
Expand Down Expand Up @@ -412,7 +421,7 @@ void TestQgsGeometry::bufferCheck()
delete mypBufferGeometry;
QVERIFY( renderCheck( "geometry_bufferCheck", "Checking buffer(10,10) of B" ) );
}
bool TestQgsGeometry::renderCheck( QString theTestName, QString theComment )
bool TestQgsGeometry::renderCheck( QString theTestName, QString theComment , int mismatchCount )
{
mReport += "<h2>" + theTestName + "</h2>\n";
mReport += "<h3>" + theComment + "</h3>\n";
Expand Down

0 comments on commit f0efa6d

Please sign in to comment.