Avoid a cpp check dangling pointer warning

qgis · Apr 15, 2023 · eda48ee · eda48ee
1 parent e3af648
commit eda48ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/app/layers/qgsapplayerhandling.cpp b/src/app/layers/qgsapplayerhandling.cpp
@@ -1540,9 +1540,7 @@ void QgsAppLayerHandling::resolveVectorLayerDependencies( QgsVectorLayer *vl, Qg
               std::unique_ptr< QgsVectorLayer > newVl = std::make_unique< QgsVectorLayer >( layerUri, !dependency.name.isEmpty() ? dependency.name : tableName, providerName );
               if ( newVl->isValid() )
               {
-                QgsVectorLayer *res = newVl.get();
-                QgsProject::instance()->addMapLayer( newVl.release() );
-                return res;
+                return qobject_cast< QgsVectorLayer *>( QgsProject::instance()->addMapLayer( newVl.release() ) );
               }
             }
             catch ( QgsProviderConnectionException & )

diff --git a/src/app/qgsstatisticalsummarydockwidget.h b/src/app/qgsstatisticalsummarydockwidget.h
@@ -134,7 +134,7 @@ class APP_EXPORT QgsStatisticalSummaryDockWidget : public QgsDockWidget, private
 
     QString mExpression;
 
-    QgsStatisticsValueGatherer *mGatherer = nullptr;
+    QPointer< QgsStatisticsValueGatherer > mGatherer;
 
     bool mPendingCalculate = false;
 };