Skip to content

Commit

Permalink
Remove unneeded todos (conn gets closed when shared ptr is deleted)
Browse files Browse the repository at this point in the history
  • Loading branch information
wonder-sk committed Sep 9, 2021
1 parent 4800b29 commit ed04756
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/providers/mssql/qgsmssqltransaction.cpp
Expand Up @@ -142,7 +142,6 @@ bool QgsMssqlTransaction::commitTransaction( QString &error )
}

error = mConn->db().lastError().text();
// TODO? mConn.reset(); // should delete conn if we're the last ones
return false;
}

Expand All @@ -155,6 +154,5 @@ bool QgsMssqlTransaction::rollbackTransaction( QString &error )
}

error = mConn->db().lastError().text();
// TODO? mConn.reset(); // should delete conn if we're the last ones
return false;
}

0 comments on commit ed04756

Please sign in to comment.