Added const and Q_FOREACH instead of plain foreach

elpaso · elpaso · commit ecaadef7eb57 · 2015-10-29T09:36:46.000+01:00
diff --git a/src/gui/symbology-ng/qgsstylev2exportimportdialog.cpp b/src/gui/symbology-ng/qgsstylev2exportimportdialog.cpp
@@ -394,10 +394,10 @@ void QgsStyleV2ExportImportDialog::clearSelection()
 
 void QgsStyleV2ExportImportDialog::selectSymbols( const QStringList symbolNames )
 {
-  foreach ( QString symbolName, symbolNames )
+  Q_FOREACH( const QString &symbolName, symbolNames )
   {
     QModelIndexList indexes = listItems->model()->match( listItems->model()->index( 0, 0 ), Qt::DisplayRole, symbolName , 1, Qt::MatchFixedString | Qt::MatchCaseSensitive );
-    foreach ( QModelIndex index, indexes )
+    Q_FOREACH ( const QModelIndex &index, indexes )
     {
       listItems->selectionModel()->select( index, QItemSelectionModel::Select );
     }
@@ -406,10 +406,10 @@ void QgsStyleV2ExportImportDialog::selectSymbols( const QStringList symbolNames
 
 void QgsStyleV2ExportImportDialog::deselectSymbols( const QStringList symbolNames )
 {
-  foreach ( QString symbolName, symbolNames )
+  Q_FOREACH ( const QString &symbolName, symbolNames )
   {
     QModelIndexList indexes = listItems->model()->match( listItems->model()->index( 0, 0 ), Qt::DisplayRole, symbolName , 1, Qt::MatchFixedString | Qt::MatchCaseSensitive );
-    foreach ( QModelIndex index, indexes )
+    Q_FOREACH ( const QModelIndex &index, indexes )
     {
       QItemSelection deselection( index, index );
       listItems->selectionModel()->select( deselection, QItemSelectionModel::Deselect );

Original file line number	Diff line number	Diff line change
`@@ -394,10 +394,10 @@ void QgsStyleV2ExportImportDialog::clearSelection()`
`394`	`394`
`395`	`395`	`void QgsStyleV2ExportImportDialog::selectSymbols( const QStringList symbolNames )`
`396`	`396`	`{`
`397`		`- foreach ( QString symbolName, symbolNames )`
	`397`	`+ Q_FOREACH( const QString &symbolName, symbolNames )`
`398`	`398`	`{`
`399`	`399`	`QModelIndexList indexes = listItems->model()->match( listItems->model()->index( 0, 0 ), Qt::DisplayRole, symbolName , 1, Qt::MatchFixedString \| Qt::MatchCaseSensitive );`
`400`		`- foreach ( QModelIndex index, indexes )`
	`400`	`+ Q_FOREACH ( const QModelIndex &index, indexes )`
`401`	`401`	`{`
`402`	`402`	`listItems->selectionModel()->select( index, QItemSelectionModel::Select );`
`403`	`403`	`}`
`@@ -406,10 +406,10 @@ void QgsStyleV2ExportImportDialog::selectSymbols( const QStringList symbolNames`
`406`	`406`
`407`	`407`	`void QgsStyleV2ExportImportDialog::deselectSymbols( const QStringList symbolNames )`
`408`	`408`	`{`
`409`		`- foreach ( QString symbolName, symbolNames )`
	`409`	`+ Q_FOREACH ( const QString &symbolName, symbolNames )`
`410`	`410`	`{`
`411`	`411`	`QModelIndexList indexes = listItems->model()->match( listItems->model()->index( 0, 0 ), Qt::DisplayRole, symbolName , 1, Qt::MatchFixedString \| Qt::MatchCaseSensitive );`
`412`		`- foreach ( QModelIndex index, indexes )`
	`412`	`+ Q_FOREACH ( const QModelIndex &index, indexes )`
`413`	`413`	`{`
`414`	`414`	`QItemSelection deselection( index, index );`
`415`	`415`	`listItems->selectionModel()->select( deselection, QItemSelectionModel::Deselect );`