Fix crash when opening entity form from layer without attribute

rouault · rouault · commit ec820762d65e · 2014-06-16T21:55:02.000+02:00
When right-clicking in the attribute table of a layer that has
no attribute, no feature is selected. If selecting the 'Edit form'
entry, we got a crash.
diff --git a/src/gui/attributetable/qgsfeaturelistview.cpp b/src/gui/attributetable/qgsfeaturelistview.cpp
@@ -144,10 +144,14 @@ void QgsFeatureListView::editSelectionChanged( QItemSelection deselected, QItemS
   QItemSelection currentSelection = mCurrentEditSelectionModel->selection();
   if ( currentSelection.size() == 1 )
   {
-    QgsFeature feat;
-    mModel->featureByIndex( mModel->mapFromMaster( currentSelection.indexes().first() ), feat );
+    QModelIndexList indexList = currentSelection.indexes();
+    if ( !indexList.isEmpty() )
+    {
+      QgsFeature feat;
+      mModel->featureByIndex( mModel->mapFromMaster( indexList.first() ), feat );
 
-    emit currentEditSelectionChanged( feat );
+      emit currentEditSelectionChanged( feat );
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -144,10 +144,14 @@ void QgsFeatureListView::editSelectionChanged( QItemSelection deselected, QItemS`
`144`	`144`	`QItemSelection currentSelection = mCurrentEditSelectionModel->selection();`
`145`	`145`	`if ( currentSelection.size() == 1 )`
`146`	`146`	`{`
`147`		`- QgsFeature feat;`
`148`		`- mModel->featureByIndex( mModel->mapFromMaster( currentSelection.indexes().first() ), feat );`
	`147`	`+ QModelIndexList indexList = currentSelection.indexes();`
	`148`	`+ if ( !indexList.isEmpty() )`
	`149`	`+ {`
	`150`	`+ QgsFeature feat;`
	`151`	`+ mModel->featureByIndex( mModel->mapFromMaster( indexList.first() ), feat );`
`149`	`152`
`150`		`- emit currentEditSelectionChanged( feat );`
	`153`	`+ emit currentEditSelectionChanged( feat );`
	`154`	`+ }`
`151`	`155`	`}`
`152`	`156`	`}`
`153`	`157`