Greetings from Anita and Tim at the QGIS Hackfest in Vienna (Nov 2009). We have just fixed bug #2011 (Crash using Identify Feature)...Wheeeeee

timlinux · timlinux · commit ea9c9ff70ac7 · 2009-11-06T10:42:11.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk@11927 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/qgsmaptoolidentify.cpp b/src/app/qgsmaptoolidentify.cpp
@@ -72,6 +72,10 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )
     return;
   }
 
+  if ( !mResults )
+  {
+    mResults = new QgsIdentifyResults( mCanvas, mCanvas->window() );
+  }
   mResults->clear();
 
   QSettings settings;
@@ -147,6 +151,10 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )
 
 void QgsMapToolIdentify::activate()
 {
+  if ( !mResults ) 
+  {
+    mResults = new QgsIdentifyResults( mCanvas, mCanvas->window() );
+  }
   mResults->activate();
   QgsMapTool::activate();
 }
diff --git a/src/app/qgsmaptoolidentify.h b/src/app/qgsmaptoolidentify.h
@@ -24,6 +24,7 @@
 #include "qgsdistancearea.h"
 
 #include <QObject>
+#include <QPointer>
 
 class QgsIdentifyResults;
 class QgsMapLayer;
@@ -71,7 +72,7 @@ class QgsMapToolIdentify : public QgsMapTool
     bool identifyVectorLayer( QgsVectorLayer *layer, int x, int y );
 
     //! Pointer to the identify results dialog for name/value pairs
-    QgsIdentifyResults *mResults;
+    QPointer<QgsIdentifyResults> mResults;
 
     //! Private helper
     void convertMeasurement( QgsDistanceArea &calc, double &measure, QGis::UnitType &u, bool isArea );

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,10 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )`
`72`	`72`	`return;`
`73`	`73`	`}`
`74`	`74`
	`75`	`+ if ( !mResults )`
	`76`	`+ {`
	`77`	`+ mResults = new QgsIdentifyResults( mCanvas, mCanvas->window() );`
	`78`	`+ }`
`75`	`79`	`mResults->clear();`
`76`	`80`
`77`	`81`	`QSettings settings;`
`@@ -147,6 +151,10 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )`
`147`	`151`
`148`	`152`	`void QgsMapToolIdentify::activate()`
`149`	`153`	`{`
	`154`	`+ if ( !mResults )`
	`155`	`+ {`
	`156`	`+ mResults = new QgsIdentifyResults( mCanvas, mCanvas->window() );`
	`157`	`+ }`
`150`	`158`	`mResults->activate();`
`151`	`159`	`QgsMapTool::activate();`
`152`	`160`	`}`