[composer] Manually removing a frame from a multi frame forces the mu…

…lti frame to UseExistingFrames mode, otherwise the frame may not actually be removed. This changes makes the behaviour of multi frames a bit more predictable (sponsored by City of Uster, Switzerland)
qgis · Apr 28, 2014 · e9b253d · e9b253d
1 parent 86304b9
commit e9b253d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/core/composer/qgscomposermultiframe.cpp b/src/core/composer/qgscomposermultiframe.cpp
@@ -17,13 +17,20 @@
 #include "qgscomposerframe.h"
 #include "qgscomposition.h"
 
-QgsComposerMultiFrame::QgsComposerMultiFrame( QgsComposition* c, bool createUndoCommands ): mComposition( c ), mResizeMode( UseExistingFrames ), mCreateUndoCommands( createUndoCommands )
+QgsComposerMultiFrame::QgsComposerMultiFrame( QgsComposition* c, bool createUndoCommands ):
+    mComposition( c ),
+    mResizeMode( UseExistingFrames ),
+    mCreateUndoCommands( createUndoCommands ),
+    mIsRecalculatingSize( false )
 {
   mComposition->addMultiFrame( this );
   connect( mComposition, SIGNAL( nPagesChanged() ), this, SLOT( handlePageChange() ) );
 }
 
-QgsComposerMultiFrame::QgsComposerMultiFrame(): mComposition( 0 ), mResizeMode( UseExistingFrames )
+QgsComposerMultiFrame::QgsComposerMultiFrame():
+    mComposition( 0 ),
+    mResizeMode( UseExistingFrames ),
+    mIsRecalculatingSize( false )
 {
 }
 
@@ -159,6 +166,13 @@ void QgsComposerMultiFrame::handleFrameRemoval( QgsComposerItem* item )
   mFrameItems.removeAt( index );
   if ( mFrameItems.size() > 0 )
   {
+    if ( resizeMode() != QgsComposerMultiFrame::RepeatOnEveryPage && !mIsRecalculatingSize )
+    {
+      //removing a frame forces the multi frame to UseExistingFrames resize mode
+      //otherwise the frame may not actually be removed, leading to confusing ui behaviour
+      mResizeMode = QgsComposerMultiFrame::UseExistingFrames;
+      emit changed();
+    }
     recalculateFrameSizes();
   }
 }
@@ -206,10 +220,17 @@ void QgsComposerMultiFrame::handlePageChange()
 
 void QgsComposerMultiFrame::removeFrame( int i )
 {
+  if ( i >= mFrameItems.count() )
+  {
+    return;
+  }
+
   QgsComposerFrame* frameItem = mFrameItems[i];
   if ( mComposition )
   {
+    mIsRecalculatingSize = true;
     mComposition->removeComposerItem( frameItem );
+    mIsRecalculatingSize = false;
   }
   mFrameItems.removeAt( i );
 }

diff --git a/src/core/composer/qgscomposermultiframe.h b/src/core/composer/qgscomposermultiframe.h
@@ -92,6 +92,8 @@ class CORE_EXPORT QgsComposerMultiFrame: public QObject
   private:
     QgsComposerMultiFrame(); //forbidden
 
+    bool mIsRecalculatingSize;
+
   signals:
     void changed();
 };