Fix tests

nyalldawson · nyalldawson · commit e863dc669b20 · 2018-04-02T13:01:12.000+10:00
(cherry-picked from d9e9f2a)
diff --git a/src/core/qgsvectorfilewritertask.cpp b/src/core/qgsvectorfilewritertask.cpp
@@ -47,7 +47,7 @@ void QgsVectorFileWriterTask::cancel()
 
 bool QgsVectorFileWriterTask::run()
 {
-  if ( !mError != QgsVectorFileWriter::NoError )
+  if ( mError != QgsVectorFileWriter::NoError )
     return false;
 
   connect( mOptions.feedback, &QgsFeedback::progressChanged, this, &QgsVectorFileWriterTask::setProgress );
diff --git a/tests/src/python/test_qgsvectorfilewritertask.py b/tests/src/python/test_qgsvectorfilewritertask.py
@@ -97,8 +97,8 @@ def testLayerRemovalBeforeRun(self):
         while not self.success and not self.fail:
             QCoreApplication.processEvents()
 
-        self.assertFalse(self.success)
-        self.assertTrue(self.fail)
+        self.assertTrue(self.success)
+        self.assertFalse(self.fail)
 
     def testNoLayer(self):
         """test that failure (and not crash) occurs when no layer set"""

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ void QgsVectorFileWriterTask::cancel()`
`47`	`47`
`48`	`48`	`bool QgsVectorFileWriterTask::run()`
`49`	`49`	`{`
`50`		`- if ( !mError != QgsVectorFileWriter::NoError )`
	`50`	`+ if ( mError != QgsVectorFileWriter::NoError )`
`51`	`51`	`return false;`
`52`	`52`
`53`	`53`	`connect( mOptions.feedback, &QgsFeedback::progressChanged, this, &QgsVectorFileWriterTask::setProgress );`