Fix memory leak

qgis · Aug 31, 2017 · e84543d · e84543d
1 parent 75c65c5
commit e84543d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/core/qgsuserprofilemanager.cpp b/src/core/qgsuserprofilemanager.cpp
@@ -71,7 +71,7 @@ void QgsUserProfileManager::setRootLocation( QString rootProfileLocation )
   {
     mWatcher->addPath( mRootProfilePath );
   }
-  mSettings = new QSettings( settingsFile(), QSettings::IniFormat );
+  mSettings.reset( new QSettings( settingsFile(), QSettings::IniFormat ) );
 }
 
 bool QgsUserProfileManager::rootLocationIsSet() const
@@ -172,7 +172,7 @@ QgsError QgsUserProfileManager::deleteProfile( const QString name )
   return error;
 }
 
-QString QgsUserProfileManager::settingsFile()
+QString QgsUserProfileManager::settingsFile() const
 {
   return  mRootProfilePath + QDir::separator() + "profiles.ini";
 }

diff --git a/src/core/qgsuserprofilemanager.h b/src/core/qgsuserprofilemanager.h
@@ -179,9 +179,9 @@ class CORE_EXPORT QgsUserProfileManager : public QObject
 
     std::unique_ptr<QgsUserProfile> mUserProfile;
 
-    QString settingsFile();
+    QString settingsFile() const;
 
-    QSettings *mSettings = nullptr;
+    std::unique_ptr< QSettings > mSettings;
 };
 
 #endif // QGSUSERPROFILEMANAGER_H