Fix some Coverity null pointer dereference warnings

nyalldawson · nyalldawson · commit e7ddfff09d9d · 2017-09-01T07:54:20.000+10:00
diff --git a/src/gui/qgsattributeform.cpp b/src/gui/qgsattributeform.cpp
@@ -2037,7 +2037,7 @@ bool QgsAttributeForm::fieldIsEditable( int fieldIndex ) const
     int srcFieldIndex;
     const QgsVectorLayerJoinInfo *info = mLayer->joinBuffer()->joinForFieldIndex( fieldIndex, mLayer->fields(), srcFieldIndex );
 
-    if ( !info->hasUpsertOnEdit() && mMode == QgsAttributeForm::AddFeatureMode )
+    if ( info && !info->hasUpsertOnEdit() && mMode == QgsAttributeForm::AddFeatureMode )
       editable = false;
     else if ( info && info->isEditable() && info->joinLayer()->isEditable() )
       editable = fieldIsEditable( *( info->joinLayer() ), srcFieldIndex, mFeature.id() );
diff --git a/src/providers/ogr/qgsgeopackagedataitems.cpp b/src/providers/ogr/qgsgeopackagedataitems.cpp
@@ -383,7 +383,7 @@ bool QgsGeoPackageConnectionItem::handleDrop( const QMimeData *data, Qt::DropAct
         {
           if ( isVector ) // Import vectors and aspatial
           {
-            QgsVectorLayer *vectorSrcLayer = dynamic_cast < QgsVectorLayer * >( srcLayer );
+            QgsVectorLayer *vectorSrcLayer = qobject_cast < QgsVectorLayer * >( srcLayer );
             QVariantMap options;
             options.insert( QStringLiteral( "driverName" ), QStringLiteral( "GPKG" ) );
             options.insert( QStringLiteral( "update" ), true );

Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ bool QgsGeoPackageConnectionItem::handleDrop( const QMimeData *data, Qt::DropAct`
`383`	`383`	`{`
`384`	`384`	`if ( isVector ) // Import vectors and aspatial`
`385`	`385`	`{`
`386`		`- QgsVectorLayer vectorSrcLayer = dynamic_cast < QgsVectorLayer >( srcLayer );`
	`386`	`+ QgsVectorLayer vectorSrcLayer = qobject_cast < QgsVectorLayer >( srcLayer );`
`387`	`387`	`QVariantMap options;`
`388`	`388`	`options.insert( QStringLiteral( "driverName" ), QStringLiteral( "GPKG" ) );`
`389`	`389`	`options.insert( QStringLiteral( "update" ), true );`